Update Report_ActionItem#9139
Merged
Merged
Conversation
Contributor
Author
|
I'm putting this on HOLD while I verify what needs to come before it. I think there may need to be some API PRs that happen first (not 100% sure yet though). |
added 2 commits
May 24, 2022 11:23
Contributor
Author
|
OK, I verified that this one is safe to merge without the other changes happening. The unpassed props evaluate to false because of the |
Justicea83
suggested changes
May 24, 2022
roryabraham
reviewed
May 25, 2022
added 2 commits
May 26, 2022 13:44
Contributor
Author
|
Updated |
roryabraham
approved these changes
May 26, 2022
Contributor
|
All yours @Justicea83 |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
22 tasks
Contributor
|
🚀 Deployed to staging by @Justicea83 in version: 1.1.69-0 🚀
|
Contributor
|
🚀 Deployed to production by @luacmartins in version: 1.1.69-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR adds the pending and error states to Report_ActionItem and uses them to set the opacity to 50%.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/211551