[No QA] Docs updates for E/A#90029 Update Spend page filter popover UI docs#91759
Conversation
Reflects the changes from E/A#90029 which updates the advanced filters button to open a popover on web and a full-screen view on mobile, with Apply and Reset buttons. Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>
HelpDot Documentation ReviewOverall AssessmentThis PR updates the "Getting Started with the Spend Page" article to document the new advanced filter popover UI introduced in PR #90029. It adds platform-specific (Web/Mobile) step-by-step instructions, updates keywords, improves a heading to be task-based, and adds a cross-link to the search operators article. The changes are well-scoped and generally align with governance standards, with a few items to address. Scores Summary
Key FindingsPositive aspects:
Items to address:
Recommendations
Files Reviewed
Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6acb03f406
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
The existing page describes the behavior as it is, I don't think this update is needed. |
|
Eh decided to edit to more accurately represent how to search |
|
A preview of your ExpensifyHelp changes have been deployed to https://e0f7ee9b.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|
Summary
Changes
docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md: Updated the "How to Use Filters" section with platform-specific instructions for the new advanced filter UI, added cross-link to search operators article, and updated heading to be task-based per authoring guidelines.@bernhardoj, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.