Skip to content

Add story for InlineSystemMessage#9198

Merged
Gonals merged 2 commits into
mainfrom
Rory-CleanupInlineSystemMessage
May 27, 2022
Merged

Add story for InlineSystemMessage#9198
Gonals merged 2 commits into
mainfrom
Rory-CleanupInlineSystemMessage

Conversation

@roryabraham

@roryabraham roryabraham commented May 27, 2022

Copy link
Copy Markdown
Contributor

@Gonals will you please review this?

Details

This PR does two things:

  • Uses theme instead of color for an icon color
  • Adds a storybook story for the InlineSystemMessage component.

Fixed Issues

$ n/a

Tests

  1. Run npm run storybook
  2. Look at the new story:

image

@roryabraham roryabraham requested a review from Gonals May 27, 2022 00:17
@roryabraham roryabraham self-assigned this May 27, 2022
@roryabraham roryabraham requested a review from a team as a code owner May 27, 2022 00:17
@melvin-bot melvin-bot Bot requested review from thienlnam and removed request for a team May 27, 2022 00:17

@Luke9389 Luke9389 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@Gonals Gonals merged commit 3780ccd into main May 27, 2022
@Gonals Gonals deleted the Rory-CleanupInlineSystemMessage branch May 27, 2022 08:01
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.69-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @luacmartins in version: 1.1.69-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants