InteractionManager migration - ShareRootPage#92172
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c5f53691e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
heyjennahay
left a comment
There was a problem hiding this comment.
Product review not required
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari Screen.Recording.2026-06-01.at.16.57.47.moviOS: Native Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-06-01.at.16.57.14.mov |
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM
Migration to remove InteractionManager.runAfterInteractions usage from ShareRootPage.tsx and replace with built-in auto-focus behavior. The PR simplifies the code by removing ref chains and useImperativeHandle hooks.
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
roryabraham
left a comment
There was a problem hiding this comment.
Favorite PR of the day. I love removing code we don't need.
| "../../src/pages/Search/SearchMoneyRequestReportPage.tsx" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 1 | ||
| "../../src/pages/Search/SearchPage.tsx" "react-hooks/set-state-in-effect" 1 | ||
| "../../src/pages/Search/SearchTransactionsChangeReport.tsx" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 1 | ||
| "../../src/pages/Share/ShareRootPage.tsx" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 1 |
There was a problem hiding this comment.
NAB: Manually tightening the seatbelt file isn't necessary
There was a problem hiding this comment.
Got it, will keep that in mind in the new PRs
|
@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.98-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no documentation changes required. I reviewed the changes in this PR against the help site files under Conclusion: This is a purely internal/technical refactor with no user-facing behavior change, so no help site updates are needed and no draft PR was created. Why no docs changes are requiredThis PR replaces the deprecated
From a user's perspective, the Share and Submit tabs, their inputs, and the overall flow are unchanged — only the internal mechanism that focuses the search input when switching tabs is different. There are no new features, UI labels, settings, tabs, or workflow changes to document. A search of |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.98-3 🚀
|
Explanation of Change
Replacing
InteractionManager.runAfterInteractionsusage with text input auto focus, which, from what I've tested, works best when switching between tabs on the Share screen. Comparing toInteractionManager,TransitionTrackerand no wrapper for thefocus()call, it works smoothest and in my case never missed focus.This is for native apps only.
Fixed Issues
$ #71913
$ #83069
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-01.at.10.04.50.mov
iOS: Native
Screen.Recording.2026-06-01.at.10.02.56.mov