[Payment due @marufsharifi] [No QA] Fire search requests for visible todos by s77rt · Pull Request #92299 · Expensify/App

s77rt · 2026-06-01T23:40:02Z

Explanation of Change

Fire search requests for visible todos

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/643382
PROPOSAL:

Tests

Go to Spend
Notice if you have any "to submit", "to approve", "to pay" or "to export" TODOs
Logout
Login
Verify that for every TODO a Search request is made (they could be other requests too)

Screen.Recording.2026-06-02.at.1.21.58.AM.mov

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

n/a

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-06-01T23:41:31Z

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35a54a0252

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-06-02T00:07:48Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...rc/pages/home/YourSpendSection/useYourSpendData.ts	`97.35% <90.90%> (-0.54%)`	⬇️
... and 6 files with indirect coverage changes

Copilot

Pull request overview

This PR extends the existing search-firing effect on the Spend home page to also fire Search requests for the visible TODO suggested searches (Submit / Approve / Pay / Export), in addition to the card and approval/payment queries it already fires. This ensures TODO row counts on the Spend page stay fresh after login/focus.

Changes:

Imports getSuggestedSearches, getSuggestedSearchesVisibility, and TODO_SEARCH_KEYS from SearchUIUtils.
Reads email from useCurrentUserPersonalDetails and computes suggested-search visibility (passing empty card feeds and undefined default Expensify card, since neither affects TODO visibility).
In fireSearches, iterates over TODO_SEARCH_KEYS and dispatches a search for each visible TODO with shouldCalculateTotals: false.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

marufsharifi · 2026-06-02T08:37:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5166398f20

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

flaviadefaria · 2026-06-02T11:49:52Z

No new product considerations - removing my assignment and unsubscribing.

marufsharifi · 2026-06-03T03:34:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Not Required

Android: mWeb Chrome

Not Required

iOS: HybridApp

Not Required

iOS: mWeb Safari

Not Required

MacOS: Chrome / Safari

luacmartins

LGTM. We have conflicts and failing checks though

s77rt · 2026-06-03T20:31:33Z

Resolved conflicts. Failed tests seemed unrelated (Pagination stuff) and hopefully they are fixed now

s77rt · 2026-06-03T20:41:55Z

Another test failed now but also looks unrelated. Can you please rerun that one

luacmartins · 2026-06-03T21:16:51Z

Failed on retry. Running again

melvin-bot · 2026-06-04T04:48:14Z

🎯 @marufsharifi, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/643382.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

marufsharifi · 2026-06-04T04:48:41Z

Changes LGTM; the failure is unrelated. thanks.

mountiny

@s77rt can you sync main again, hopefully some of the flaky test fixes already been applied

s77rt · 2026-06-04T13:53:54Z

Merged main

mountiny · 2026-06-04T14:05:17Z

Carlos approved before so I will merge it

luacmartins · 2026-06-04T15:17:04Z

Nice! Can't wait to remove the Search calls from OpenApp

github-actions · 2026-06-04T15:31:51Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-04T15:55:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92299.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1a26c023bbf-6f3f8d5-e093b8bc75f6094fa152ea8df850d701a6131290/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1a26c02-6f3f8d5-e1c93e885f1957aa588f0c7a03411cdc16252dab/index.html

Web 🕸️
https://92299.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-05T18:16:43Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-05T18:18:15Z

🤖 Help site review: no changes required

I reviewed the changes in this PR and no updates to the help site (docs/articles) are needed.

Why: This PR is a behind-the-scenes data-fetching optimization. It fires Search requests for visible "to submit / to approve / to pay / to export" todos when the app loads, so that data is ready sooner. The only changed file is src/pages/home/YourSpendSection/useYourSpendData.ts.

There is no change to any user-facing feature, UI label, tab, setting, button, or workflow that a help article describes — it's purely when data loads, not what a user sees or does. Since the help site documents user-facing behavior, no draft PR was created.

OSBotify · 2026-06-09T04:10:57Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot · 2026-06-09T04:14:33Z

🤖 Payment issue created: #92989

aldo-expensify · 2026-06-10T18:08:28Z

        }
        fireSearches();
-    }, [isFocused, isOffline, displayableCardIDsKey, applicabilityKey]);
+    }, [isFocused, isOffline, displayableCardIDsKey, applicabilityKey, suggestedSearchesVisibility]);


@s77rt @mountiny isn't suggestedSearchesVisibility a new object every render? wouldn't watching it trigger the useEffect every time?

Coming from: https://expensify.slack.com/archives/C0B96MS9B8X/p1781114792126269?thread_ts=1781114404.944699&cid=C0B96MS9B8X

Discussed in https://expensify.slack.com/archives/C086VHWPPUM/p1781121889869979

load search todos on openapp

35a54a0

melvin-bot Bot assigned s77rt Jun 1, 2026

s77rt marked this pull request as ready for review June 1, 2026 23:41

s77rt requested review from a team as code owners June 1, 2026 23:41

melvin-bot Bot requested review from flaviadefaria and nkuoch and removed request for a team June 1, 2026 23:41

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx Outdated

move search calls to useYourSpendData hook

a6a1b76

only fire search for visible todos

5166398

s77rt changed the title ~~Get search data on OpenApp~~ [No QA] Fire search requests for visible todos Jun 2, 2026

mountiny requested review from Copilot and mountiny June 2, 2026 07:32

Copilot started reviewing on behalf of mountiny June 2, 2026 07:32 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

mountiny requested a review from marufsharifi June 2, 2026 08:33

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts

flaviadefaria removed their request for review June 2, 2026 11:50

s77rt added 2 commits June 3, 2026 03:36

Merge branch 'main' into get-search-data-on-openapp

29086e4

fire searchs on suggestedSearchesVisibility change

fc85cd6

flodnv requested review from luacmartins and removed request for nkuoch June 3, 2026 08:34

luacmartins reviewed Jun 3, 2026

View reviewed changes

merge main

d6b30f4

s77rt dismissed mountiny’s stale review via d6b30f4 June 3, 2026 20:30

Merge branch 'Expensify:main' into get-search-data-on-openapp

fa07448

luacmartins mentioned this pull request Jun 3, 2026

Refactor chart default typefaces behind shared provider #92534

Merged

63 tasks

marufsharifi approved these changes Jun 4, 2026

View reviewed changes

melvin-bot Bot changed the title ~~[No QA] Fire search requests for visible todos~~ [Payment due @marufsharifi] [No QA] Fire search requests for visible todos Jun 4, 2026

mountiny approved these changes Jun 4, 2026

View reviewed changes

Merge branch 'Expensify:main' into get-search-data-on-openapp

1cdf6a2

mountiny merged commit 1a26c02 into Expensify:main Jun 4, 2026
31 checks passed

github-actions Bot mentioned this pull request Jun 4, 2026

Investigate workflow job failing on main: test / test (job 4) #92690

Closed

OSBotify mentioned this pull request Jun 5, 2026

Deploy Checklist: New Expensify 2026-06-05 #92792

Closed

melvin-bot Bot mentioned this pull request Jun 9, 2026

[Due for payment 2026-06-16] Payment issue for E/App PR#92299 #92989

Closed

aldo-expensify reviewed Jun 10, 2026

View reviewed changes

luacmartins mentioned this pull request Jun 10, 2026

Revert "[Payment due @marufsharifi] [No QA] Fire search requests for visible todos" #93201

Merged

51 tasks

s77rt mentioned this pull request Jun 10, 2026

[Payment due @marufsharifi] Fire search requests for visible todos (2) #93213

Merged

51 tasks

luacmartins pushed a commit that referenced this pull request Jun 15, 2026

apply changes from #92299

be9e4c8

Conversation

s77rt commented Jun 1, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Jun 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

marufsharifi commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

flaviadefaria commented Jun 2, 2026

Uh oh!

marufsharifi commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

s77rt commented Jun 3, 2026

Uh oh!

s77rt commented Jun 3, 2026

Uh oh!

luacmartins commented Jun 3, 2026

Uh oh!

melvin-bot Bot commented Jun 4, 2026

Uh oh!

marufsharifi commented Jun 4, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

s77rt commented Jun 4, 2026

Uh oh!

mountiny commented Jun 4, 2026

Uh oh!

Uh oh!

luacmartins commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

OSBotify commented Jun 5, 2026

Uh oh!

MelvinBot commented Jun 5, 2026

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

melvin-bot Bot commented Jun 9, 2026

Uh oh!

aldo-expensify Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

s77rt Jun 10, 2026

Choose a reason for hiding this comment

s77rt commented Jun 1, 2026 •

edited by mountiny

Loading

codecov Bot commented Jun 2, 2026 •

edited by github-actions Bot

Loading

marufsharifi commented Jun 3, 2026 •

edited

Loading