-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[hold] [No QA] Docs updates for E/A#92009 document spend rule step in card issuing #92316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -61,18 +61,36 @@ You can issue virtual or physical cards to employees: | |||||||||
| - **Fixed limit**: Spend until the limit is reached | ||||||||||
| - **Single-use (virtual only)**: Expires after one transaction | ||||||||||
| 6. Enter the spending limit | ||||||||||
| 7. (Optional for virtual cards) Toggle **Set expiration date** to define: | ||||||||||
| - **Start date** | ||||||||||
| - **End date** | ||||||||||
| - **When enabled:** Both dates are required. The card activates at 12:00 AM local time on the Start date and expires at 11:59 PM local time on the End date. | ||||||||||
| - **When disabled:** The card does not expire automatically. | ||||||||||
| 7. On the **Set card rules** step, apply a spend rule and set an expiration date: | ||||||||||
| - To restrict where and how the card can be used, toggle **Add spend rule** on, then choose: | ||||||||||
| - **Copy existing**: Reuse an existing spend rule. Click **Choose a rule** and select one from the list. | ||||||||||
| - **Create new**: Build a new rule. Set the restriction type to **Allow** or **Block**, then add any combination of **Merchant**, **Spend category**, and **Max amount**. | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Readability / structure: This triple-nested bullet packs three distinct actions into one line (set restriction type, choose Allow/Block, add Merchant/Spend category/Max amount). Per Section 5 of HELP_AUTHORING_GUIDELINES.md, step instructions must be clear and action-oriented. Consider breaking this into separate sub-bullets:
Suggested change
|
||||||||||
| - (Virtual cards only) Toggle **Add expiration date** to define: | ||||||||||
| - **Start date** | ||||||||||
| - **End date** | ||||||||||
| - **When enabled:** Both dates are required. The card activates at 12:00 AM local time on the Start date and expires at 11:59 PM local time on the End date. | ||||||||||
| - **When disabled:** The card does not expire automatically. | ||||||||||
| 8. Name the card for easier tracking | ||||||||||
| 9. Click **Issue card** to confirm | ||||||||||
| 9. On the confirmation screen, review the details — including the **Restrictions** summary if you applied a spend rule — then click **Issue card** to confirm | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Readability / structure: This step combines a review action and a confirm action into one long sentence with an em-dash parenthetical, which hurts scannability. Per Section 5 of HELP_AUTHORING_GUIDELINES.md, steps must be clear and action-oriented. Consider splitting into two steps: |
||||||||||
|
|
||||||||||
| The **Add spend rule** option appears only when **Rules** is enabled for the workspace. | ||||||||||
|
|
||||||||||
| {:width="100%"} | ||||||||||
|
|
||||||||||
| {:width="100%"} | ||||||||||
|
|
||||||||||
| <!-- SCREENSHOT: | ||||||||||
| Suggestion: The Set card rules step with Add spend rule toggled on, showing the Copy existing / Create new tabs and the Merchant, Spend category, and Max amount fields. | ||||||||||
| Location: After the Step 3 issue card numbered list. | ||||||||||
| Purpose: Shows admins where to apply a spend rule while issuing a card. | ||||||||||
| --> | ||||||||||
|
|
||||||||||
| <!-- SCREENSHOT: | ||||||||||
| Suggestion: The issue card confirmation screen showing the Restrictions row that summarizes the applied spend rule. | ||||||||||
| Location: After the Step 3 issue card numbered list. | ||||||||||
| Purpose: Shows admins how applied restrictions appear before clicking Issue card. | ||||||||||
| --> | ||||||||||
|
|
||||||||||
| --- | ||||||||||
|
|
||||||||||
| # Monitor and Manage Cards | ||||||||||
|
|
@@ -168,6 +186,10 @@ Yes. You can link a single Expensify Card feed to multiple workspaces using the | |||||||||
| - **Yes**: Employees can have unlimited **virtual cards** (e.g. for trips or subscriptions). | ||||||||||
| - **Yes**: Employees can be issued multiple physical cards with different limit types. | ||||||||||
|
|
||||||||||
| ## Can I restrict where an Expensify Card can be used when I issue it? | ||||||||||
|
|
||||||||||
| Yes. When **Rules** is enabled for the workspace, the **Set card rules** step lets you toggle **Add spend rule** on and either **Copy existing** to reuse an existing spend rule or **Create new** to build one. A spend rule can **Allow** or **Block** spend based on **Merchant**, **Spend category**, and **Max amount**. Any restrictions you apply appear under **Restrictions** on the confirmation screen before you click **Issue card**. | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Readability / structure: This FAQ answer is a single dense sentence that covers multiple concepts (enabling Rules, toggling Add spend rule, Copy existing vs. Create new, Allow/Block, three field types, and the confirmation screen). For scannability, consider restructuring as a short intro sentence followed by a bullet list summarizing the key options, similar to how the procedural steps above break this down. |
||||||||||
|
|
||||||||||
| ## How is the Expensify Card limit determined? | ||||||||||
|
|
||||||||||
| The limit is the maximum combined spending limit for all Expensify Cards in your domain. It’s calculated using: | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For production users, this spend-rule control is not shown even when workspace Rules is enabled; I checked
SetSpendRulesStepand the UI is gated by!isProduction && isPolicyFeatureEnabled(...). Publishing these steps in the help article will send admins looking for an Add spend rule toggle they cannot access until the feature ships, so this section should be gated/removed from the live docs or explicitly held until production rollout.Useful? React with 👍 / 👎.