Don't use from:me for payment history search#92356
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosBecause my accounts lack the billing history, I will verify the Search API using the specific account ID instead of the 'me' alias Android: HybridAppScreen.Recording.2026-06-03.at.01.32.35.movAndroid: mWeb ChromeScreen.Recording.2026-06-03.at.01.20.25.moviOS: HybridAppScreen.Recording.2026-06-03.at.01.29.35.moviOS: mWeb SafariScreen.Recording.2026-06-03.at.01.29.35.movMacOS: Chrome / SafariScreen.Recording.2026-06-03.at.01.18.19.mov |
|
🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.3.98-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no changes required. This PR is a bug fix to the View payment history link in No help site files under
Help articles document intended product behavior, and this change brings the product back in line with what's already documented — so there's nothing to add or correct. No draft PR was created since no documentation updates are needed. If you'd like a docs change anyway (e.g. an FAQ entry), reply with |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.98-3 🚀
|
Explanation of Change
We can't build a filter with
from:mesince it uses the string literalmeinstead of using the account ID. Also removes the status filter, since it includes all statuses, which is the defaultFixed Issues
$ #92292
Tests
Have an account with billing history
Go to Account > Subscription > View payment history
User should see all their billing receipts when navigated to the Spend page
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-06-02.at.8.14.49.AM.mov