[No QA] Update section header for account security#92400
Conversation
Removing a number from the Account Security header
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Kel-Expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://7eb0548d.helpdot.pages.dev ⚡️ Updated articles: |
| --- | ||
|
|
||
| # 6. Secure Your Account | ||
| # Secure Your Account |
There was a problem hiding this comment.
Heading level violation: Per HELP_AUTHORING_GUIDELINES.md (Sections 4 and 9), an article must have exactly one # heading (the article title), plus an optional # FAQ. All other content sections must use ##. This heading should be demoted to ##.
Note: While removing the numbered prefix "6." is a positive change (numbered prefixes like "Step 1" are forbidden generic headings), the heading level still needs to change from # to ##.
| # Secure Your Account | |
| ## Secure Your Account |
(This same # vs ## issue applies to several other section headings in this file — e.g., "# Meet Concierge", "# Add a Business Bank Account", "# Connect an Accounting System", "# Set Approval Rules", "# Navigating Multiple Workspaces" — but those are pre-existing and outside the scope of this PR's diff.)
HelpDot Documentation ReviewOverall AssessmentThis PR removes the numbered prefix "6." from the heading Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on governance rules defined in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. |
|
@Kel-Expensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/Kel-Expensify in version: 9.3.98-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.98-3 🚀
|
Explanation of Change
Fixed Issues
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.