Upgrade React Native to 0.85.3#92484
Conversation
|
|
…temporary metro overrides for rock, patch metro-source-map
# Conflicts: # package-lock.json # patches/react-native/react-native+0.85.3+036+rounded-inline-code-background.patch
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # package-lock.json # package.json
# Conflicts: # ios/Podfile.lock # package-lock.json # package.json
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # package-lock.json # package.json
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de92138f98
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| process.env.EXPO_PUBLIC_USE_RN_FETCH = process.env.EXPO_PUBLIC_USE_RN_FETCH ?? '1'; | ||
|
|
||
| const BaseReactCompilerConfig = require('./config/babel/reactCompilerConfig'); | ||
| const {expoInlineEnvVars} = require('babel-preset-expo/build/plugins/inline-env-vars'); |
There was a problem hiding this comment.
When this config is loaded after installing this commit's babel-preset-expo@56.0.15, the package exposes build/inline-env-vars.js at the build root and does not contain a build/plugins/ directory, so Metro/Jest/Webpack Babel startup will throw Cannot find module 'babel-preset-expo/build/plugins/inline-env-vars' before any transform runs. Require babel-preset-expo/build/inline-env-vars instead.
Useful? React with 👍 / 👎.
# Conflicts: # Mobile-Expensify # android/app/build.gradle # ios/NewExpensify/Info.plist # ios/NotificationServiceExtension/Info.plist # ios/ShareViewController/Info.plist # package-lock.json # package.json
…R_SETTLED_ANIMATIONS
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Asked for testing https://expensify.slack.com/archives/C09V78U42D8/p1781878732664569 |
3 participants
Explanation of Change
Fixed Issues
$
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13959
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari