[No QA] Update help docs for Releases 1-4: Expensify Card Spend Rules#92580
Merged
Conversation
Add a new Spend Rules article covering default protections, Block rules, Allow rules, evaluation order, rule management, and search. Cross-reference Spend Rules from the card setup, cardholder, troubleshooting, and notifications articles. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @zanyrenney |
|
@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
stephanieelliott
changed the title
Contributor
|
Copy is good, just need to test the UI steps to confirm they're right - will just before release when it is on staging. |
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a well-structured new article for Expensify Card Spend Rules and adds cross-references to four existing card articles. The new article covers a clear single workflow (admin Spend Rule management) and follows governance structure closely. There are several issues that should be addressed before merge, including a typo, heading compliance gaps, a full URL that should be relative, and minor formatting errors. Scores Summary
Key FindingsIssues to address:
Positive aspects:
Recommendations
Files Reviewed
Note: This review assessed only the proposed changes (diff), not unchanged portions of the files. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d012537df9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
stephanieelliott
added
the
HelpDot
Contributor
|
Build for testing: https://92681.pr-testing.expensify.com/ |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
stephanieelliott
changed the title
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Fixed the failing Spell check — it was the only non-checklist check that failed. Cause: a typo Fix: corrected it to |
Contributor
stephanieelliott
changed the title
stephanieelliott
approved these changes
Jun 13, 2026
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
Contributor
|
🚀 Deployed to staging by https://github.com/clarajones-expensify in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to staging by https://github.com/clarajones-expensify in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR adds the help site documentation for the Expensify Card Spend Rules feature, consolidating the resource updates for all four releases (Releases 1–4) into a single set of article changes.
Spend Rules let Workspace Admins approve or decline Expensify Card transactions in real time at the point of sale, before any expense is created. Because the feature is conceptually distinct from both card setup (limits/issuance) and post-submission expense rules, it gets a dedicated article, with light cross-references added to the existing card articles for discoverability.
New article
docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md— covers default protections, Block rules, Allow rules, evaluation order, editing/deleting rules, applying a rule at card issuance, and the search filter (admin workflow).Updated articles
Set-Up-and-Manage-the-Expensify-Card.md— notes that a Spend Rule can be applied when issuing a card, and that default protections + Spend Rules exist, with a link to the new article.Cardholder-Settings-and-Features.md— adds a "View Spend Rules on Your Card" section and adds Spend Rule restrictions (with Concierge decline notifications) as a decline reason.Troubleshoot-Expensify-Card-issues.md— adds a "Transaction declined by a Spend Rule" troubleshooting subsection.Expensify-Card-Notifications.md— documents the Concierge notification a cardholder receives when a Spend Rule declines a transaction.Note
This feature is being built across Releases 1–4 and the docs describe its end state. UI labels (e.g., the Spend section, Add card rule, Contains/Exact match, the Workspace > Rules and Wallet > Card Details entry points) are taken from the design doc and should be verified against the shipped product before merge.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/641928
Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate the help docs render correctly and the content is accurate.
Offline tests
N/A — help site documentation change only.
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review", or add "[No QA]" to the title if appropriate for a docs-only change.