Fix BBA `PENDING` state validation by VickyStash · Pull Request #92773 · Expensify/App

VickyStash · 2026-06-05T13:00:21Z

Explanation of Change

This PR fixes bank account navigation for accounts in the PENDING state, which regressed with the per-step routing refactor in #88193.

Before #88193, opening a USD bank account in the PENDING state rendered the Validate transactions step. After the refactor, each step became its own own route, so the existing condition in ReimbursementAccountPage no longer produced a correct navigation state.

With current setup we can't fully skip ReimbursementAccountPage because it fetches the main reimbursement account data first — only once that data loads, we know which step the user should be on. Rather than automatically re-navigate user to the Validate transactions step directly, this PR shows the Continue setup step first, from which the user proceeds into Validate transactions. Pressing back from Validate transactions returns the user right back to the previous screen.

Fixed Issues

$ #79048
PROPOSAL: N/A

Slack thread: https://expensify.slack.com/archives/C05LX9D6E07/p1780507170988739

Tests

Verify that no errors appear in the JS console

Open the app
Go to Workspaces -> any Workspace
Enable Workflows feature and open it
Enable Payments
Tap Add bank account
Set up the bank account manually so that it ends up in the PENDING state (you may need Expensify help to change the state from VERIFYING to PENDING).
Tap on the bank account and make sure you see the Continue setup button -> tap on it.
You should be navigated to the Validate step.
Press the back button on the Validate step -> you should be just navigated back.
Repeat steps 7-9 from the Wallet page.

Offline tests

Same, as in the Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

ios_web.mov

MacOS: Chrome / Safari

web.mp4

VickyStash · 2026-06-05T13:00:58Z

@codex review

chatgpt-codex-connector · 2026-06-05T13:05:30Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-06-05T13:06:20Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../ReimbursementAccount/ReimbursementAccountPage.tsx	`0.00% <0.00%> (ø)`
...mentAccount/USD/USDVerifiedBankAccountFlowPage.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

melvin-bot · 2026-06-05T13:42:55Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

I was part of the discussion on the related issue. LGTM

VickyStash · 2026-06-08T12:53:14Z

Kind bump @dukenv0307 🙂

dukenv0307 · 2026-06-08T14:19:32Z

on it now

dukenv0307 · 2026-06-08T15:04:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-08.at.22.03.33.mov

Android: mWeb Chrome

Screen.Recording.2026-06-08.at.21.57.27.mov

iOS: HybridApp

Screen.Recording.2026-06-08.at.22.01.15.mov

iOS: mWeb Safari

Screen.Recording.2026-06-08.at.21.58.31.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-08.at.21.54.49.mov

arosiclair · 2026-06-08T18:24:29Z

@VickyStash conflicts

# Conflicts: # src/pages/ReimbursementAccount/USD/USDVerifiedBankAccountFlowPage.tsx

JmillsExpensify

LGTM

JmillsExpensify · 2026-06-09T09:53:29Z

cc @joekaufmanexpensify in case you want to review this PR as well.

github-actions · 2026-06-09T12:47:57Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-09T16:18:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-09T16:21:51Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-09T16:28:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92773.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ba47db3ae02-79c0e20-6eee618cad6da24774a8c7a4d862d658bfc3f054/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ba47db3-79c0e20-ffffd16bc5e6fe53301983f6b02d39b14d5b19b9/index.html

Web 🕸️
https://92773.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-10T01:02:00Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-10T19:55:21Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.4-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-10T23:19:28Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix PENDING state validation

95dd88f

melvin-bot Bot assigned VickyStash Jun 5, 2026

VickyStash changed the title ~~Fix PENDING state validation~~ Fix BBA PENDING state validation Jun 5, 2026

VickyStash marked this pull request as ready for review June 5, 2026 13:42

VickyStash requested review from a team as code owners June 5, 2026 13:42

melvin-bot Bot requested review from JmillsExpensify and dukenv0307 and removed request for a team June 5, 2026 13:42

JmillsExpensify previously approved these changes Jun 5, 2026

View reviewed changes

dukenv0307 approved these changes Jun 8, 2026

View reviewed changes

melvin-bot Bot requested a review from arosiclair June 8, 2026 15:04

arosiclair previously approved these changes Jun 8, 2026

View reviewed changes

Merge branch 'main' into VickyStash/bugfix/pending-state-validation

9b47d4c

# Conflicts: # src/pages/ReimbursementAccount/USD/USDVerifiedBankAccountFlowPage.tsx

VickyStash dismissed stale reviews from arosiclair and JmillsExpensify via 9b47d4c June 9, 2026 07:47

JmillsExpensify approved these changes Jun 9, 2026

View reviewed changes

joekaufmanexpensify self-requested a review June 9, 2026 12:46

This comment has been minimized.

Sign in to view

Merge branch 'main' into VickyStash/bugfix/pending-state-validation

0bf69df

arosiclair merged commit ba47db3 into Expensify:main Jun 9, 2026
31 checks passed

OSBotify mentioned this pull request Jun 10, 2026

Deploy Checklist: New Expensify 2026-06-10 #93122

Closed

70 tasks

applause-bot Bot mentioned this pull request Jun 10, 2026

[Exploratory] Bank Account - Personal Info page opens after deleting account number #93149

Open

7 tasks

melvin-bot Bot mentioned this pull request Jun 10, 2026

[Due for payment 2026-06-17] [Due for payment 2026-06-04] [CBN] Refactor the enable payments flow (USD & Intl') #79048

Closed

Conversation

VickyStash commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

VickyStash commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 5, 2026

Uh oh!

codecov Bot commented Jun 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 5, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

VickyStash commented Jun 8, 2026

Uh oh!

dukenv0307 commented Jun 8, 2026

Uh oh!

dukenv0307 commented Jun 8, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

arosiclair commented Jun 8, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

This comment has been minimized.

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Jun 5, 2026 •

edited

Loading

codecov Bot commented Jun 5, 2026 •

edited by github-actions Bot

Loading