Skip to content

[No QA] Docs updates for E/A#92116 Travel toggle locks while Travel Invoicing is on#92801

Merged
stephanieelliott merged 2 commits into
mainfrom
melvin-docsTravelInvoicingLocksTravelToggle
Jun 13, 2026
Merged

[No QA] Docs updates for E/A#92116 Travel toggle locks while Travel Invoicing is on#92801
stephanieelliott merged 2 commits into
mainfrom
melvin-docsTravelInvoicingLocksTravelToggle

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

App PR #92116 locks the Travel toggle in Workspace settings → More features whenever Travel Invoicing is enabled. An admin can no longer turn Travel off directly — pressing the locked toggle opens a message explaining that Travel Invoicing must be turned off first, with a Go to Travel settings button.

This is a new, user-facing constraint that wasn't documented on the help site, so a Workspace Admin who hits the locked toggle currently has nothing to search for. This PR documents the dependency in the two relevant Travel articles:

  • Enable Expensify Travel on a workspace — adds a ## Why can’t I turn off Travel? FAQ with the exact steps to turn off Travel Invoicing first, then Travel.
  • Enable Travel Invoicing on a Workspace — adds a bullet to What happens after you enable Travel Invoicing noting that the Travel toggle is locked while Travel Invoicing is on.

All UI labels (More features, Travel, Go to Travel settings, Travel Invoicing) were verified against src/languages/en.ts and follow HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

Fixed Issues

Related to #92116
$
PROPOSAL:

Tests

Documentation-only change. No code was modified.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation-only change.

QA Steps

Documentation-only change. No code was modified.

  • Verify that no errors appear in the JS console

@blimpich, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Benjamin Limpich <blimpich@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team June 5, 2026 18:20
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 5, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Failing check: build (Deploy ExpensifyHelp) — CI infrastructure, not this PR

Root cause: The Install pcregrep step fails with E: Unable to locate package pcregrep on the blacksmith-2vcpu-ubuntu-2404 runner. The step runs sudo apt-get install -y pcregrep with no preceding apt-get update, so a stale/empty apt package index makes the package unresolvable. This is unrelated to the documentation changes in this PR.

Evidence it's environmental (not this PR):

  • Every pull_request run of this workflow since ~18:19 UTC today is failing the same way — docs-intacct-travel-invoicing-cr, melvin-docs-auditor-readonly-workspace, claude-docs-qbo-travel-invoicing-cr, docs-xero-travel-invoicing-cr, and this branch.
  • push runs to main at 15:05 UTC and earlier today succeeded using the identical step, which proves pcregrep is installable on this runner — the apt index just needs refreshing.

Fix: Run apt-get update before the install in .github/workflows/deployExpensifyHelp.yml:40-41:

      - name: Install pcregrep
        run: |
          sudo apt-get update
          sudo apt-get install -y pcregrep

⚠️ I can't push this fix. My token lacks the workflow scope, so GitHub rejects any push that modifies a file under .github/workflows/ (refusing to allow a Personal Access Token to create or update workflow ... without 'workflow' scope). Because this affects every docs PR right now, the cleanest path is a small standalone infra PR with the one-line change above, made by someone whose credentials have workflow scope. Once that lands on main, re-running this PR's build check will pass.

@blimpich blimpich marked this pull request as ready for review June 12, 2026 16:36
@melvin-bot

melvin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot melvin-bot Bot requested review from CortneyOfstad and removed request for a team June 12, 2026 16:36
@melvin-bot

melvin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions github-actions Bot changed the title Docs updates for E/A#92116 Travel toggle locks while Travel Invoicing is on [No QA] Docs updates for E/A#92116 Travel toggle locks while Travel Invoicing is on Jun 12, 2026
@OSBotify

This comment has been minimized.

Comment thread docs/articles/travel/company-setup/Enable-Travel-on-a-Workspace.md Outdated

## Why can’t I turn off Travel?

If **Travel Invoicing** is enabled for your workspace, the **Travel** toggle in **More features** is locked, because Travel Invoicing requires Travel to stay on. When you press the locked toggle, a message appears asking you to turn off Travel Invoicing first.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-standard action verb: "When you press the locked toggle" uses "press", which is not a standard action verb in HelpDot articles. Per HELPSITE_NAMING_CONVENTIONS.md, use Click (web) or Tap (mobile). Since this sentence is platform-neutral, consider rephrasing to: "When you click the locked toggle, a message appears..."

1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**.
2. Click your workspace name to access the settings for that workspace.
3. In the left menu, click **More features**.
4. Press the locked **Travel** toggle, then click **Go to Travel settings**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-standard action verb: "Press the locked Travel toggle" uses "press" instead of the standard "Click" / "Tap". Per HELPSITE_NAMING_CONVENTIONS.md, always use exact standard verbs. Consider:

Suggested change
4. Press the locked **Travel** toggle, then click **Go to Travel settings**.
4. Click the locked **Travel** toggle, then click **Go to Travel settings**.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new FAQ entry to the Enable Travel article explaining why the Travel toggle may be locked (due to Travel Invoicing), and adds a corresponding bullet point to the Travel Invoicing article noting the same behavior. The changes are small, well-scoped, and generally well-written. They address a real user question with clear, actionable steps.

Scores Summary

  • Readability: 9/10 - The new FAQ answer is clear, concise, and scannable. Steps are sequential and action-oriented. The bullet point addition in the Travel Invoicing article is direct and easy to understand.
  • AI Readiness: 9/10 - The FAQ heading "Why can't I turn off Travel?" is question-based and matches real search intent. It uses the exact feature name. No metadata changes were needed since this is an addition to existing articles with valid YAML frontmatter.
  • Style Compliance: 8/10 - UI elements are correctly bolded (Travel, More features, Travel Invoicing, Go to Travel settings). Navigation instructions use the correct unified format. One minor issue noted below.

Key Findings

  • The FAQ heading follows governance rules: it starts with a question word ("Why") and is task/feature-specific.
  • UI element bolding is consistently applied throughout the new content.
  • The navigation instruction in step 1 correctly uses the unified format: "on the left on web, and at the bottom on mobile" -- though note the governance file specifies "on the bottom on mobile" without "and at the", this is a very minor stylistic variance and reads naturally.
  • Cross-linking at the end uses the recommended "Learn more about [Feature Name]" anchor text pattern and a relative link, both compliant with cross-linking standards.
  • The link is correctly placed after the procedural steps, not within them.
  • Step 1 uses "click" for Workspaces, which is appropriate. Steps are sequential and aligned with the actual UI flow.
  • Minor style note: Step 4 uses "Press the locked Travel toggle" while step 1 uses "click." The governance files do not mandate a specific verb for toggles, but consistency within a single set of steps would be ideal. Consider using "click" throughout for consistency, or "tap" if this is specifically for mobile. The mixed use of "press" and "click" may cause slight confusion.

Recommendations

  • Consider standardizing the verb in step 4 from "Press" to "Click" to match the verb used in the other steps within the same instruction set. The word "press" appears only once across the new content and diverges from the "click" convention used elsewhere.
  • No other changes are strictly required. The content is well-structured and governance-compliant.

Files Reviewed

  • docs/articles/travel/company-setup/Enable-Travel-on-a-Workspace.md - New FAQ entry added ("Why can't I turn off Travel?"). Well-structured with clear steps and proper cross-link.
  • docs/articles/travel/travel-invoicing/Enable-Travel-Invoicing-in-a-Workspace.md - New bullet point added explaining the locked Travel toggle behavior. Concise and informative.

Note: This review covers only the proposed changes in the diff, not pre-existing content.

CortneyOfstad
CortneyOfstad previously approved these changes Jun 12, 2026
…e.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@OSBotify

Copy link
Copy Markdown
Contributor

@stephanieelliott stephanieelliott merged commit 2fa5241 into main Jun 13, 2026
15 checks passed
@stephanieelliott stephanieelliott deleted the melvin-docsTravelInvoicingLocksTravelToggle branch June 13, 2026 03:53
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants