[No QA] Docs updates for E/A#92116 Travel toggle locks while Travel Invoicing is on#92801
Conversation
Co-authored-by: Benjamin Limpich <blimpich@users.noreply.github.com>
Failing check:
|
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
|
|
||
| ## Why can’t I turn off Travel? | ||
|
|
||
| If **Travel Invoicing** is enabled for your workspace, the **Travel** toggle in **More features** is locked, because Travel Invoicing requires Travel to stay on. When you press the locked toggle, a message appears asking you to turn off Travel Invoicing first. |
There was a problem hiding this comment.
Non-standard action verb: "When you press the locked toggle" uses "press", which is not a standard action verb in HelpDot articles. Per HELPSITE_NAMING_CONVENTIONS.md, use Click (web) or Tap (mobile). Since this sentence is platform-neutral, consider rephrasing to: "When you click the locked toggle, a message appears..."
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**. | ||
| 2. Click your workspace name to access the settings for that workspace. | ||
| 3. In the left menu, click **More features**. | ||
| 4. Press the locked **Travel** toggle, then click **Go to Travel settings**. |
There was a problem hiding this comment.
Non-standard action verb: "Press the locked Travel toggle" uses "press" instead of the standard "Click" / "Tap". Per HELPSITE_NAMING_CONVENTIONS.md, always use exact standard verbs. Consider:
| 4. Press the locked **Travel** toggle, then click **Go to Travel settings**. | |
| 4. Click the locked **Travel** toggle, then click **Go to Travel settings**. |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new FAQ entry to the Enable Travel article explaining why the Travel toggle may be locked (due to Travel Invoicing), and adds a corresponding bullet point to the Travel Invoicing article noting the same behavior. The changes are small, well-scoped, and generally well-written. They address a real user question with clear, actionable steps. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review covers only the proposed changes in the diff, not pre-existing content. |
…e.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://b5071460.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀
|
Explanation of Change
App PR #92116 locks the Travel toggle in Workspace settings → More features whenever Travel Invoicing is enabled. An admin can no longer turn Travel off directly — pressing the locked toggle opens a message explaining that Travel Invoicing must be turned off first, with a Go to Travel settings button.
This is a new, user-facing constraint that wasn't documented on the help site, so a Workspace Admin who hits the locked toggle currently has nothing to search for. This PR documents the dependency in the two relevant Travel articles:
## Why can’t I turn off Travel?FAQ with the exact steps to turn off Travel Invoicing first, then Travel.All UI labels (More features, Travel, Go to Travel settings, Travel Invoicing) were verified against
src/languages/en.tsand followHELPSITE_NAMING_CONVENTIONS.md,HELP_AUTHORING_GUIDELINES.md, andTEMPLATE.md.Fixed Issues
Related to #92116
$
PROPOSAL:
Tests
Documentation-only change. No code was modified.
Offline tests
N/A — documentation-only change.
QA Steps
Documentation-only change. No code was modified.
@blimpich, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.