perf: search autocomplete optimization by rinej · Pull Request #92938 · Expensify/App

rinej · 2026-06-08T14:56:01Z

Explanation of Change

On native, the search autocomplete screen stays mounted behind a chat after navigating into it, leaving the heavy SearchAutocompleteList in memory. This PR adds a useIsFocusedUntilTransitionEnd hook that swaps the list for a lightweight skeleton once the closing transition finishes, keeping it mounted only through the animation so navigation never blanks mid-transition.

Fixed Issues

#91846
PROPOSAL:

Tests

Open the app on a mobile device (iOS or Android)
Open Search
Select one of the recent chats
Type and send a new message in the chat
Go back using:
- a) the top navigation back button
- b) the swipe-back gesture
Verify the recent chat shows the new message as its latest message preview
Try it 2-3 times

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-06-08T15:00:20Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useIsFocusedUntilTransitionEnd.ts	`100.00% <100.00%> (ø)`
...ch/DeferredSearchAutocompleteList/index.native.tsx	`0.00% <0.00%> (ø)`
... and 26 files with indirect coverage changes

…-SearchAutocompleteList

LukasMod · 2026-06-12T07:50:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cafb86b75

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-12T07:54:04Z

+            return;
+        }
+
+        const unsubscribe = navigation.addListener('transitionEnd', () => setDidTransitionOut(true));


Add a fallback when transitionEnd is missed

When native/iOS navigation misses transitionEnd—a case this repo already guards against in src/components/ScreenWrapper/index.tsx:203 and src/hooks/useAutoFocusInput.ts:104 with CONST.SCREEN_TRANSITION_END_TIMEOUT—this listener never runs and didTransitionOut stays false. In the Search → chat path from issue #91846, that makes useIsFocusedUntilTransitionEnd() keep returning true, so DeferredAutocompleteList continues rendering the heavy SearchAutocompleteList behind the chat and the intended message-send performance fix is skipped for those transitions.

Useful? React with 👍 / 👎.

…-SearchAutocompleteList

LukasMod · 2026-06-12T08:36:32Z

@codex review

chatgpt-codex-connector · 2026-06-12T08:43:34Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: e2c3e2fcf6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-06-12T08:45:39Z

Test: Recent Chat Message Update (only mobile native)

Open the app on a mobile device (iOS or Android)
Open Search
Select one of the recent chats
Type and send a new message in the chat
Go back using:
a) the top navigation back button
b) the swipe-back gesture
Verify the recent chat shows the new message as its latest message preview
Try it 2-3 times

melvin-bot · 2026-06-15T10:34:58Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

No product review required

nyomanjyotisa · 2026-06-17T17:42:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android-Native.mp4

Android: mWeb Chrome

iOS: HybridApp

iOS-Native.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-06-17T17:43:25Z

🎯 @nyomanjyotisa, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

cristipaval · 2026-06-17T18:42:18Z

🎯 @nyomanjyotisa, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production. E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

No need for a payment issue. I assigned @nyomanjyotisa to the fixed issue

github-actions · 2026-06-17T18:50:39Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-17T18:55:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-17T18:56:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92938.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6135aa84db2-29bf4e2-9074288df76bde3b9149b5372d76f3cf6e915e26/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6135aa8-29bf4e2-532c82a44875f5e5867c90f5d03c26c3d86263cc/index.html

Web 🕸️
https://92938.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-18T17:17:40Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.4.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-06-18T17:20:22Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under App/docs/articles.

This is a purely internal performance/memory optimization — it adds a useIsFocusedUntilTransitionEnd hook that unmounts the heavy SearchAutocompleteList (swapping it for a lightweight skeleton) once the search screen loses focus on native, keeping it mounted only through the closing transition. The end-user-visible behavior is unchanged: Search, recent chats, and message sending all work exactly as before, just without the background re-rendering that was slowing message send.

Because there's no change to any user-facing feature, flow, setting, tab, or button label, there's nothing in the public help site that needs to be updated. No draft docs PR was created.

@rinej, let me know if you believe any user-facing behavior actually changed here and I'll re-evaluate and open a docs PR if needed.

OSBotify · 2026-06-19T15:23:32Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

perf: search autocomplete optimization

0ae2c83

melvin-bot Bot assigned rinej Jun 8, 2026

rinej mentioned this pull request Jun 8, 2026

[$250] Investigate SearchAutocompleteList causing 2x slowdown during message sending #91846

Open

rinej and others added 6 commits June 9, 2026 14:18

remove onyx freeze

07ccaf2

Merge branch 'main' of github.com:Expensify/App into perf-investigate…

1c56076

…-SearchAutocompleteList

clean up temporary flag, leave proposal A only

64cac34

add useIsFocusedUntilTransitionEnd and guard SearchAutocompleteList

a8d8824

use navigation transitionEnd inside DeferredAutocompleteList

00c4783

clean up

8cafb86

chatgpt-codex-connector Bot reviewed Jun 12, 2026

View reviewed changes

LukasMod added 3 commits June 12, 2026 09:57

Merge branch 'main' of github.com:Expensify/App into perf-investigate…

93f88f0

…-SearchAutocompleteList

add iOS edge case fix

5fce362

add unit tests

e2c3e2f

Merge branch 'main' into perf-investigate-SearchAutocompleteList

f04b764

rinej marked this pull request as ready for review June 15, 2026 10:34

rinej requested review from a team as code owners June 15, 2026 10:34

melvin-bot Bot requested review from Gonals and JmillsExpensify and removed request for a team June 15, 2026 10:34

cristipaval requested review from cristipaval and nyomanjyotisa and removed request for Gonals June 15, 2026 11:18

JmillsExpensify reviewed Jun 15, 2026

View reviewed changes

nyomanjyotisa approved these changes Jun 17, 2026

View reviewed changes

melvin-bot Bot changed the title ~~perf: search autocomplete optimization~~ [Payment due @nyomanjyotisa] perf: search autocomplete optimization Jun 17, 2026

cristipaval changed the title ~~[Payment due @nyomanjyotisa] perf: search autocomplete optimization~~ perf: search autocomplete optimization Jun 17, 2026

cristipaval approved these changes Jun 17, 2026

View reviewed changes

cristipaval merged commit 6135aa8 into Expensify:main Jun 17, 2026
38 of 41 checks passed

OSBotify mentioned this pull request Jun 18, 2026

Deploy Checklist: New Expensify 2026-06-18 #93956

Closed

45 tasks

Conversation

rinej commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LukasMod commented Jun 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

LukasMod Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

LukasMod commented Jun 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 12, 2026

Uh oh!

LukasMod commented Jun 12, 2026

Test: Recent Chat Message Update (only mobile native)

Uh oh!

melvin-bot Bot commented Jun 15, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa commented Jun 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 17, 2026

Uh oh!

cristipaval commented Jun 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

MelvinBot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rinej commented Jun 8, 2026 •

edited

Loading

codecov Bot commented Jun 8, 2026 •

edited by github-actions Bot

Loading