Skip to content

[No QA] Docs updates for E/A#92681 document Expensify Card spend rules#93354

Merged
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-spend-rules-92681
Jun 13, 2026
Merged

[No QA] Docs updates for E/A#92681 document Expensify Card spend rules#93354
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-spend-rules-92681

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Documents the Spend rules feature for Expensify Cards, which was enabled in production via #92681 (that PR removed the !isProduction gate that previously hid spend rules).

Spend rules let Workspace Admins approve or decline Expensify Card transactions in realtime based on merchant, spend category, and amount. They appear in the Spend section of the Workspace Rules tab once the Expensify Card is enabled, and previously had no help-site coverage.

Changes

  • Added a # How to configure Spend rules for Expensify Cards section to Workspace-Rules.md, covering the built-in protection (Adult services, ATMs, gambling, money transfers), creating a rule (Restriction type Allow/Block, Add merchant, Match type, Spend category, Max amount, Choose cards, Save rule), and editing/deleting rules.
  • Added an FAQ entry explaining why the Spend section may not appear (Expensify Card not enabled).
  • Updated frontmatter keywords and internalScope for retrieval.

Notes

  • All UI labels were taken verbatim from src/languages/en.ts (e.g., workspace.rules.spendRules.*) and the component implementation, then matched to the naming conventions. Live-UI verification of this flow requires a workspace with the Expensify Card enabled and a verified US business bank account, which isn't available in this environment — please confirm the labels and steps against the live product.

Source PR: #92681
Source issue: #92391

Test plan

  • Render the updated Workspace-Rules article and confirm the new Spend rules section displays correctly.
  • Confirm every UI label (button, section, toggle, field) matches the live product exactly.

@JS00001, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Spend rules (realtime approve/decline of Expensify Card transactions) were
enabled in production in #92681. Document how Workspace Admins
create and manage them in the Spend section of the Rules tab.

Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 12, 2026
@MelvinBot MelvinBot mentioned this pull request Jun 12, 2026
54 tasks
@github-actions github-actions Bot changed the title Docs updates for E/A#92681 document Expensify Card spend rules [No QA] Docs updates for E/A#92681 document Expensify Card spend rules Jun 12, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://13d8a65f.helpdot.pages.dev ⚡️

Updated articles:

@JS00001 JS00001 marked this pull request as ready for review June 12, 2026 11:34

---

# How to configure Spend rules for Expensify Cards

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading hierarchy violation: Per HELP_AUTHORING_GUIDELINES.md Section 4 and the Pre-Publish Validation Checklist, only one # heading (the article title) is allowed, plus an optional # FAQ. All content sections must use ##. This should be ## How to configure Spend rules for Expensify Cards.

(Note: the existing file has the same issue with other # headings — those are pre-existing violations outside this PR's scope, but new content should follow the standard.)


To add your own spend rule:

1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation phrasing violation: Per HELPSITE_NAMING_CONVENTIONS.md, the standard unified navigation instruction is:

In the navigation tabs (on the left on web, on the bottom on mobile)

The phrase should be "on the bottom on mobile" not "at the bottom on mobile".

Suggested change
1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**.
1. In the **navigation tabs** (on the left on web, and on the bottom on mobile), click **Workspaces**.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new "Spend rules for Expensify Cards" section to the Workspace Rules article, including setup steps, a description of built-in protections, and a new FAQ entry. The content is well-written, clearly structured, and covers the feature thoroughly. A few governance compliance issues should be addressed before merging.

Scores Summary

  • Readability: 9/10 - Clear, scannable steps with good use of bold formatting for UI elements. The distinction between Allow and Block restriction types is well-explained inline.
  • AI Readiness: 7/10 - Metadata updates are solid, but the new section uses a # heading instead of ##, which violates the single-#-title rule. The existing article has this same pattern throughout, but the governance spec is clear that new content should not introduce additional # headings.
  • Style Compliance: 7/10 - Navigation phrasing uses "at the bottom on mobile" instead of the required "on the bottom on mobile." One FAQ answer uses shorthand navigation ("Workspaces > [Workspace Name] > More features") instead of full navigation instructions.

Key Findings

  • Heading level violation (must fix): The new section heading # How to configure Spend rules for Expensify Cards uses # instead of ##. Per HELP_AUTHORING_GUIDELINES.md Section 4, only the article title and # FAQ may use #. All other content sections must use ##. While the existing article already has this pattern, new additions should follow the current governance rules. Recommend changing to ## How to configure Spend rules for Expensify Cards.
  • Navigation phrasing (must fix): Step 1 reads "at the bottom on mobile" but HELPSITE_NAMING_CONVENTIONS.md specifies the exact phrasing "on the bottom on mobile." This should be corrected to: In the **navigation tabs** (on the left on web, on the bottom on mobile), click **Workspaces**.
  • Metadata updates (positive): The keywords and internalScope additions are well-chosen -- "spend rules," "Expensify Card spend rules," "block transactions," and "approve transactions" all reflect realistic search queries.
  • Step quality (positive): The 10-step procedure is clear, sequential, and action-oriented. Good use of "(Optional)" labels for non-required steps. UI elements are consistently bolded.
  • Cross-linking compliance (positive): Links to the Expensify Card setup article are placed outside of numbered steps, which follows the cross-linking standard. Relative links are used correctly.
  • FAQ entry (positive): The new FAQ question "Why don't I see the Spend section in Rules?" starts with a question word and addresses a realistic user concern. However, the answer uses shorthand navigation (Workspaces > [Workspace Name] > More features) rather than the full navigation instruction format required by the naming conventions.

Recommendations

  1. Change # to ## for the new "How to configure Spend rules for Expensify Cards" heading to comply with the single-title heading rule.
  2. Fix navigation phrasing from "at the bottom" to "on the bottom" in step 1.
  3. Expand the FAQ answer navigation to use the full navigation instruction format instead of the shorthand path.
  4. Consider whether the existing article's widespread use of # headings for other sections should be addressed in a follow-up cleanup PR to bring the entire article into compliance.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Workspace-Rules.md - New Spend rules section added with metadata updates and FAQ entry. Two compliance issues identified (heading level, navigation phrasing).

Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md governance standards.

@stephanieelliott stephanieelliott merged commit 55b92dd into main Jun 13, 2026
19 checks passed
@stephanieelliott stephanieelliott deleted the melvin-docs-spend-rules-92681 branch June 13, 2026 03:37
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants