[No QA] Docs updates for E/A#92681 document Expensify Card spend rules#93354
Conversation
Spend rules (realtime approve/decline of Expensify Card transactions) were enabled in production in #92681. Document how Workspace Admins create and manage them in the Spend section of the Rules tab. Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://13d8a65f.helpdot.pages.dev ⚡️ Updated articles: |
|
|
||
| --- | ||
|
|
||
| # How to configure Spend rules for Expensify Cards |
There was a problem hiding this comment.
Heading hierarchy violation: Per HELP_AUTHORING_GUIDELINES.md Section 4 and the Pre-Publish Validation Checklist, only one # heading (the article title) is allowed, plus an optional # FAQ. All content sections must use ##. This should be ## How to configure Spend rules for Expensify Cards.
(Note: the existing file has the same issue with other # headings — those are pre-existing violations outside this PR's scope, but new content should follow the standard.)
|
|
||
| To add your own spend rule: | ||
|
|
||
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**. |
There was a problem hiding this comment.
Navigation phrasing violation: Per HELPSITE_NAMING_CONVENTIONS.md, the standard unified navigation instruction is:
In the navigation tabs (on the left on web, on the bottom on mobile)
The phrase should be "on the bottom on mobile" not "at the bottom on mobile".
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**. | |
| 1. In the **navigation tabs** (on the left on web, and on the bottom on mobile), click **Workspaces**. |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new "Spend rules for Expensify Cards" section to the Workspace Rules article, including setup steps, a description of built-in protections, and a new FAQ entry. The content is well-written, clearly structured, and covers the feature thoroughly. A few governance compliance issues should be addressed before merging. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md governance standards. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀
|
Summary
Documents the Spend rules feature for Expensify Cards, which was enabled in production via #92681 (that PR removed the
!isProductiongate that previously hid spend rules).Spend rules let Workspace Admins approve or decline Expensify Card transactions in realtime based on merchant, spend category, and amount. They appear in the Spend section of the Workspace Rules tab once the Expensify Card is enabled, and previously had no help-site coverage.
Changes
# How to configure Spend rules for Expensify Cardssection toWorkspace-Rules.md, covering the built-in protection (Adult services, ATMs, gambling, money transfers), creating a rule (Restriction type Allow/Block, Add merchant, Match type, Spend category, Max amount, Choose cards, Save rule), and editing/deleting rules.keywordsandinternalScopefor retrieval.Notes
src/languages/en.ts(e.g.,workspace.rules.spendRules.*) and the component implementation, then matched to the naming conventions. Live-UI verification of this flow requires a workspace with the Expensify Card enabled and a verified US business bank account, which isn't available in this environment — please confirm the labels and steps against the live product.Source PR: #92681
Source issue: #92391
Test plan
Workspace-Rulesarticle and confirm the new Spend rules section displays correctly.@JS00001, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.