Skip to content

fix: The LHN within the Spend tab is not remembered when navigating to Inbox #93396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkdengineer wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix: The LHN within the Spend tab is not remembered when navigating to Inbox #93396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/components/Navigation/NavigationTabBar/getLastRoute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,16 @@ function getLastRoute(rootState: NavigationState, navigator: ValueOf<typeof NAVI
let lastNavigatorKey = rootState.routes.findLast((route) => route.name === navigator)?.key;

if (!lastNavigatorKey) {
const rootTabRoute = rootState.routes.findLast((route) => route.name === NAVIGATORS.TAB_NAVIGATOR);
let rootTabRoute = rootState.routes.findLast((route) => {
if (route.name !== NAVIGATORS.TAB_NAVIGATOR) {
return false;
}
const tabState = getTabState(route);
return tabState?.routes?.[tabState.index ?? 0]?.name === navigator;
Comment on lines +13 to +18

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't restore reports from an older tab stack

When an older TAB_NAVIGATOR with Inbox/Reports active exists below the current tab stack, this findLast selects that older stack before considering the topmost stack's inactive Reports state. For example on wide layout, if a user opens report A, goes to Spend, opens report B from Spend (pushing a newer Reports tab stack), then switches to Home and presses Inbox, this predicate matches the older report-A stack and navigateToChats restores A instead of the report B state the user just left in the topmost tab navigator. The active-tab preference needs to avoid overriding a newer tab navigator that already has the target navigator state.

Useful? React with 👍 / 👎.

@mkhutornyi mkhutornyi Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkdengineer thoughts?

@nkdengineer nkdengineer Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a valid case. If the Reports tab here means the report split navigator, it will be the focused route in tabState then we can find them as the last. If Reports tab means the full-screen search navigator, navigateToChats restores the report A is correct.

});
if (!rootTabRoute) {
rootTabRoute = rootState.routes.findLast((route) => route.name === NAVIGATORS.TAB_NAVIGATOR);
}
const tabState = getTabState(rootTabRoute);
lastNavigatorKey = tabState?.routes?.findLast((route) => route.name === navigator)?.key;
}
Expand Down
Loading