Reduce domain padding in line charts to minimum necessary for fitting labels by mhawryluk · Pull Request #93405 · Expensify/App

mhawryluk · 2026-06-12T09:27:47Z

Explanation of Change

Reduces the spacing in Spend/Home line charts between the Y axis and the first point, as well as between the chart edge and the last point to a reasonable minimum, while ensuring the labels don't get clipped or rotated prematurely because of it. It drops the idea of reserving minimum space for points so that they don't get clipped at the plot area boundaries, cause that's no longer an issue, as we've been rendering them using renderOutside prop for some time now. Also the padding symmetry is no longer enforced, the first point can make use of the space reserved for the Y axis labels more effectively this way.

Before	After

Fixed Issues

$ #90646
PROPOSAL: N/A

Tests

Open different line charts.
Verify no points or labels are ever clipped.
Verify there is a reduced blank space reserved for the left- and right-most labels. Due to the nature of the implementation, there could sometimes be a little extra space on the right side of the last point, especially when rotated 45 degrees, but it should be much smaller than previously.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Simulator Screenshot - iPhone 17 Pro - 2026-06-15 at 10 12 39

iOS: mWeb Safari

Simulator Screenshot - iPhone 17 Pro - 2026-06-15 at 10 24 27

MacOS: Chrome / Safari

… labels

codecov · 2026-06-12T09:33:11Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...c/components/Charts/LineChart/LineChartContent.tsx	`3.61% <0.00%> (-1.15%)`	⬇️
... and 341 files with indirect coverage changes

github-actions · 2026-06-12T13:04:09Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

shawnborton · 2026-06-12T19:39:02Z

Looks beautiful to me:

Let's Get This Merged? Cc @Expensify/design 4viz

dannymcclain · 2026-06-12T19:50:02Z

Love it! Crazy how removing that little bit of padding makes these somehow feel more legit? 😂

shawnborton · 2026-06-12T19:58:00Z

Big agree!

dubielzyk-expensify · 2026-06-14T22:53:09Z

Looking good to me as well :)

mhawryluk · 2026-06-15T07:33:23Z

awesome! I will clean up the code and make this ready for review soon

mateuuszzzzz

Looks great, both code-wise and visually! Also, awesome that we dropped this outdated minimum space logic

borys3kk

code looks great, love the visual aspect as well, LGTM 🚀

melvin-bot · 2026-06-15T09:29:56Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-06-15T09:36:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-06-15.12.10.32.mov

Android: mWeb Chrome

2026-06-15.12.10.32.mov

iOS: HybridApp

2026-06-15.12.03.51.mov

iOS: mWeb Safari

2026-06-15.11.59.13.mov

MacOS: Chrome / Safari

2026-06-15.11.54.31.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e35b30753

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-15T09:37:29Z

-        return {...BASE_DOMAIN_PADDING, left: horizontalPadding, right: horizontalPadding};
+        return {
+            ...BASE_DOMAIN_PADDING,
+            left: Math.max(0, measurements.firstLabelWidth / 2 - chartPaddingLeft),


Clamp left padding when labels rotate

When a line chart has dense or long labels (for example, expense results grouped by merchant/category with view:line), labelsExceedTickSpacing makes the right side reserve only a rotated-label overhang, but the left side still reserves half of the full first label width. A long first label can therefore add hundreds of pixels of empty space before the first point and squeeze the plot even though the label will be rotated/truncated by useChartLabelLayout; compute the left padding from the same rotated/truncated constraints used for the right side instead of the raw horizontal width.

Useful? React with 👍 / 👎.

true, but we have limited information at the point of calculating and in this case we do indeed reserve too much space, but it's still the same or smaller than currently

actually, in some cases it could reserve more space than before or not eniugh. I made it so that when labelsExceedTickSpacing is true (we likely rotate) we reserve the space necessary for 45 degrees rotated first label, not always half the width of the first label like before. (cc: @ZhenjaHorbach)

ZhenjaHorbach · 2026-06-15T09:47:07Z

The right padding looks good for horizontal labels
But when labels are rotated, it feels like too much space is reserved on the right for the diagonal case, a diagonal last label leans down to the left, so it doesn't really stick out on the right and shouldn't need that extra padding
Should we handle the diagonal case separately and trim it down there? 😅

Although, on the other hand, it is already smaller
So probably it's okay

mhawryluk · 2026-06-15T09:58:22Z

The right padding looks good for horizontal labels But when labels are rotated, it feels like too much space is reserved on the right for the diagonal case, a diagonal last label leans down to the left, so it doesn't really stick out on the right and shouldn't need that extra padding Should we handle the diagonal case separately and trim it down there? 😅

Although, on the other hand, it is already smaller So probably it's okay

the rotated label does overhang to the right a little bit, even though it's right aligned. I did think about setting the padding to 0 in this case and letting this little overhang extend out of the plot area, but I thought that it would cause clipping. though I tried it briefly, and surprisingly it was not getting clipped, but I'm not sure why and it may be platform/library implementation dependent, so I decided to keep this little extra space, to be safe

mhawryluk · 2026-06-15T10:11:49Z

and currently the padding reserved on the right is the same for 45° and 90°, cause when we're deciding the padding we don't actually have the rotation information yet, because the rotation is determined using data that includes the padding, so there's a cycle. we could try to predict the rotation more thoroughly, but I think it would complicate the implementation and the different would be a couple pixels max and not always accurate anyway, so I'm not sure it's worth it

ZhenjaHorbach · 2026-06-15T10:12:43Z

and currently the padding reserved on the right is the same for 45° and 90°, cause when we're deciding the padding we don't actually have the rotation information yet, because the rotation is determined using data that includes the padding, so there's a cycle. we could try to predict the rotation more thoroughly, but I think it would complicate the implementation and the different would be a couple pixels max and not always accurate anyway, so I'm not sure it's worth it

It makes sense!
Let's then add a mention in the test steps for QA that it's expected

ZhenjaHorbach · 2026-06-15T11:28:39Z

Minor comment after the last changes
But now, sometimes I see small visual glitches after resizing screen
That horizontal labels are sometimes rotated, although they shouldn't change according to the screen width yet
But it literally happens in one frame
So it's edge case

mhawryluk · 2026-06-15T11:42:08Z

Minor comment after the last changes But now, sometimes I see small visual glitches after resizing screen That horizontal labels are sometimes rotated, although they shouldn't change according to the screen width yet But it literally happens in one frame So it's edge case

do you maybe have a video of that happening? it's not reproducing for me, I think

ZhenjaHorbach · 2026-06-15T11:43:44Z

Minor comment after the last changes But now, sometimes I see small visual glitches after resizing screen That horizontal labels are sometimes rotated, although they shouldn't change according to the screen width yet But it literally happens in one frame So it's edge case

do you maybe have a video of that happening? it's not reproducing for me, I think

I wanted to share
But apparently, the video doesn't have enough frame rate
And I don't see this glitch in the video 😁

ZhenjaHorbach · 2026-06-15T11:51:15Z

Although I managed to record a video

2026-06-15.13.48.51.mov

mhawryluk · 2026-06-15T13:49:12Z

hmm, I think it might be because of chartWidth and plotAreaWidth updating one render apart, but I need to dive deeper to make sure and come up with a solution. should we tackle it in this PR or is this a non-blocking issue?

ZhenjaHorbach · 2026-06-15T13:51:19Z

hmm, I think it might be because of chartWidth and plotAreaWidth updating one render apart, but I need to dive deeper to make sure and come up with a solution. should we tackle it in this PR or is this a non-blocking issue?

Definitely not critical😁

shawnborton · 2026-06-15T14:15:07Z

I think the diagonal labels above look pretty good IMO.

ZhenjaHorbach · 2026-06-15T14:46:46Z

Let's merge then!

github-actions · 2026-06-15T16:37:21Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-15T16:42:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93405.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2bd9a922ecc-c748b00-546440878eebf621bc0c9795560e9817349943e5/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2bd9a92-c748b00-69e0f55ab92ea3a2f6766b16204405a1489d00e4/index.html

Web 🕸️
https://93405.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-15T18:13:25Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

iOS

MelvinBot · 2026-06-15T18:14:54Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under App/docs/articles.

This PR is a purely internal visual refinement to line chart rendering — it reduces the domain padding (the blank space between the Y axis / chart edges and the first/last data points) in the Spend and Home line charts, while ensuring axis labels aren't clipped or prematurely rotated. The only file touched is src/components/Charts/LineChart/LineChartContent.tsx.

There are no changes to features, settings, tabs, button labels, workflows, or any user-facing functionality that the help site documents. Help articles describe what features do and how to use them — they don't document pixel-level chart spacing — so there is nothing to update and no draft PR is needed.

If you believe a specific article should be updated, let me know which one and I'll take another look.

OSBotify · 2026-06-15T19:04:31Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-15T19:06:48Z

🤖 Help site review: no docs changes required.

This PR is a purely visual rendering adjustment — it reduces the domain padding (whitespace) between the Y-axis/chart edges and the first/last points in Spend/Home line charts, and ensures labels aren't clipped or rotated prematurely. The only file touched is src/components/Charts/LineChart/LineChartContent.tsx.

No user-facing feature, workflow, setting, label, or button changes here — just chart spacing polish. Help articles document what charts show and how features work, not pixel-level layout, so there's nothing to update under docs/articles. No draft docs PR was created.

@mhawryluk, if you believe a help article does need updating as a result of this change, let me know which one and I'll draft it.

OSBotify · 2026-06-16T19:45:35Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Reduce domain padding in line charts to minimum necessary for fitting…

c1edf4e

… labels

melvin-bot Bot assigned mhawryluk Jun 12, 2026

Rename variable

5e35b30

This comment has been minimized.

Sign in to view

mateuuszzzzz approved these changes Jun 15, 2026

View reviewed changes

borys3kk approved these changes Jun 15, 2026

View reviewed changes

mhawryluk marked this pull request as ready for review June 15, 2026 09:29

mhawryluk requested review from a team as code owners June 15, 2026 09:29

melvin-bot Bot requested review from ZhenjaHorbach and trjExpensify and removed request for a team June 15, 2026 09:29

melvin-bot Bot removed the request for review from a team June 15, 2026 09:29

chatgpt-codex-connector Bot reviewed Jun 15, 2026

View reviewed changes

ZhenjaHorbach approved these changes Jun 15, 2026

View reviewed changes

melvin-bot Bot requested a review from puneetlath June 15, 2026 10:13

Reserve less space on the left when labelsExceedTickSpacing

77a1cca

puneetlath approved these changes Jun 15, 2026

View reviewed changes

puneetlath merged commit 2bd9a92 into Expensify:main Jun 15, 2026
34 checks passed

github-actions Bot mentioned this pull request Jun 15, 2026

Investigate workflow job failing on main: build (developmentDebug, false) #93599

Closed

OSBotify mentioned this pull request Jun 15, 2026

Deploy Checklist: New Expensify 2026-06-15 #93604

Closed

62 tasks

mhawryluk deleted the charts/line-reduce-domain-padding branch June 16, 2026 07:05

melvin-bot Bot mentioned this pull request Jun 16, 2026

[Due for payment 2026-06-23] [Due for payment 2026-06-19] [Due for payment 2026-06-17] Improve line chart styling with marker borders, gradient fill, and brand green color #90646

Open

Conversation

mhawryluk commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

This comment has been minimized.

shawnborton commented Jun 12, 2026

Uh oh!

dannymcclain commented Jun 12, 2026

Uh oh!

shawnborton commented Jun 12, 2026

Uh oh!

dubielzyk-expensify commented Jun 14, 2026

Uh oh!

mhawryluk commented Jun 15, 2026

Uh oh!

mateuuszzzzz left a comment

Choose a reason for hiding this comment

Uh oh!

borys3kk left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 15, 2026

Uh oh!

ZhenjaHorbach commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

mhawryluk Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

mhawryluk Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhawryluk commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhawryluk commented Jun 15, 2026

Uh oh!

ZhenjaHorbach commented Jun 15, 2026

Uh oh!

ZhenjaHorbach commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhawryluk commented Jun 15, 2026

Uh oh!

ZhenjaHorbach commented Jun 15, 2026

Uh oh!

ZhenjaHorbach commented Jun 15, 2026

Uh oh!

mhawryluk commented Jun 15, 2026

Uh oh!

ZhenjaHorbach commented Jun 15, 2026

Uh oh!

shawnborton commented Jun 15, 2026

Uh oh!

mhawryluk commented Jun 12, 2026 •

edited

Loading

codecov Bot commented Jun 12, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Jun 15, 2026 •

edited

Loading

mhawryluk Jun 15, 2026 •

edited

Loading

ZhenjaHorbach commented Jun 15, 2026 •

edited

Loading

mhawryluk commented Jun 15, 2026 •

edited

Loading

ZhenjaHorbach commented Jun 15, 2026 •

edited

Loading