Skip to content

[Home Page] Add Recently added slot to Home#93451

Merged
grgia merged 37 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/add-recently-added-slot
Jun 19, 2026
Merged

[Home Page] Add Recently added slot to Home#93451
grgia merged 37 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/add-recently-added-slot

Conversation

@adamgrzybowski

@adamgrzybowski adamgrzybowski commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Adds a new "Recently added" slot to Home that surfaces the signed-in user's most recently added expenses, sorted by the inserted timestamp (when the expense was added to the system), most recent first and independent of the expense date, and capped at five rows. Each row shows the receipt thumbnail, expense date, merchant, and amount.
  • The slot always appears: when the user has no expenses it shows an empty state.
  • Each row opens that specific expense in the RHP on Home: on narrow layouts it opens the report, and on wide layouts it opens the expense in the Wide RHP, opening optimistically so it expands to wide immediately instead of flickering from narrow to wide.
  • Relocates the "Discover" slot from the left column to the right column to keep the two-column layout balanced now that "Recently added" anchors the lower-left.

Fixed Issues

$ #92658
PROPOSAL:

Tests

Offline tests

QA Steps

  1. Open Home with an account that has expenses and verify the "Recently added" slot lists up to five expenses sorted by when they were added (an expense added today but dated months ago appears at the top), each showing receipt thumbnail, date, merchant, and amount.
  2. On a wide screen, tap an expense row and verify it opens directly in the Wide RHP without flickering from a narrow panel; on a narrow screen, verify the row opens the expense report.
  3. With an account that has no expenses, verify the empty state is shown, and use the overflow menu to verify "View all expenses" navigates to the expenses list.
  4. On a wide screen, verify the "Discover" slot now appears in the right column.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-16.at.14.23.20.mov

@melvin-bot

melvin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Triggered an adhoc, will test when it's ready.

@github-actions

This comment has been minimized.

@shawnborton

Copy link
Copy Markdown
Contributor

Hmm this is what I am seeing:
CleanShot 2026-06-12 at 21 15 56@2x

I have plenty of expenses in my account.

But regardless, the empty state does not look correct. From Figma:
image

@JmillsExpensify

Copy link
Copy Markdown
Contributor

It works for me, though the most recent expenses don't seem to be right.

@JmillsExpensify

Copy link
Copy Markdown
Contributor

It's showing my most recent expense as april 12, though on the Spend page my most recent expense is June 12

@JmillsExpensify

Copy link
Copy Markdown
Contributor

I'll share my details in Slack. Also for the empty state, we ended up changing the wording. The sub-text should be "Create one or drag a receipt here."

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

These receipts look square and I believe the should have the same aspect ratio as it has on the spend page:
CleanShot 2026-06-15 at 11 32 42@2x

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

The row is also 64px high and I believe it should be 56px, but I'm assuming we want padding set and maybe not a fixed height?
CleanShot 2026-06-15 at 11 34 12@2x

The > icon on the right should be 20x20 as well and not 16x16.

I'll let Shawn comment on the rest since he's the OG designer on it 👍

@shawnborton

Copy link
Copy Markdown
Contributor

Totally agree with those points Jon. Ideally we would share styles between the two if possible so we don't need to manage the same exact thing in multiple places.

@OSBotify

This comment has been minimized.

TDD red phase: cover the recent-expenses data hook selection (sort by
inserted, current-user scope, 5-row cap, status agnostic), the section's
empty state, rows, RHP navigation and overflow menu, and the updated Home
slot ordering with Discover relocation. Implementation follows.
@adamgrzybowski adamgrzybowski force-pushed the @adamgrzybowski/add-recently-added-slot branch from a1f0f5a to 815f807 Compare June 15, 2026 12:42
@grgia

grgia commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@adamgrzybowski ping when youre ready for a build!

@grgia grgia self-requested a review June 15, 2026 15:29
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@grgia I am fixing one more thing, will let you know soon

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@grgia @JmillsExpensify Should work now. You can retest it.

I will clean the code from any leftovers tomorrow, so I would skip the code review for now

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dannymcclain

Copy link
Copy Markdown
Contributor

Mostly asking because I would have thought that we standardized.

@JmillsExpensify Curious what you would do to standardize here? We could style the more menu as an icon button so it had a similar vibe to the view button maybe? Or we could put the view button behind a more menu to mimic the recently added card (I think I might like that better, but it's MORE CLICKS!!!! 😱). cc @Expensify/design for more thoughts on Jason's comment.

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

This is looking good! The carousel works well. The only thing I was able to find is the distance between the zoomed receipt and the transaction row. Seems a bit far, right? Example below.

@JmillsExpensify It's the same as on the spend page. The zoomed receipt is in a fixed upper left position. How would you like to change this behavior? And do you think we could do it as follow up? Would be great to finally merge this PR 😄


I know that we have fixed position for previews
But we don't show a full content and can't scroll the preview view
So it looks confusing 😅
But maybe it's okay

@ZhenjaHorbach If we want to do something about it, let's do it as follow up 🙏


Should we show optimistic expenses in Recently added also?

I would also ask for a follow up issue for that. Leaving it for later is not a deal breaker for functionality and it would speed up this PR

@ZhenjaHorbach


Minor comment
But we have different sorting in the Home and Spend screens

@ZhenjaHorbach The different sorting is by design. Spend is sorted by created and Recently Added by inserted. Can you confirm @JmillsExpensify


Playing around with the adhoc more this morning, another thing I'd like design to confirm is that we are ok with these distinct patterns?

@JmillsExpensify Let me know what the final decision is with this one, but it makes sense to me to unify this @dannymcclain

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

I don't mind fixing these issues as a follow-up!

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Same here. Everything I said above is NAB.

The hovered receipt preview is a portal on document.body that only hides on
mouseleave, so it lingered over the RHP after opening an expense. Gate it on
screen focus so it is dismissed once the home screen blurs.
@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

@JmillsExpensify Curious what you would do to standardize here? We could style the more menu as an icon button so it had a similar vibe to the view button maybe? Or we could put the view button behind a more menu to mimic the recently added card (I think I might like that better, but it's MORE CLICKS!!!! 😱). cc @Expensify/design for more thoughts on #93451 (comment).

No strong feelings. I assume @shawnborton did this for a reason. I'd expect a button, but given the Spend tab is right there I also don't mind just being more subtle here.

Copy link
Copy Markdown
Contributor

The reason we originally landed on this is because of the potentially different sort. Recently added is sorting by when something was created in Expensify, irrespective of the actual purchase/expense date. So if we just had View, then we'd potentially take you to a list of expenses that isn't the same.

This is actually why I originally didn't include a link to the Spend page. However, since Spend over time has a link, we added one to Recently added as well.

So that's how we ended where we have. Ultimately I'm fine merging this PR as is.

The Search snapshot doesn't return the transaction `inserted` field, so the
recency sort was a no-op and newly added expenses fell outside the visible
cap. Source `inserted` from the local transactions collection (falling back
to `created`) so recently added expenses sort to the top.
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

I fixed the problem with many openReport calls discussed here

One thing I want to mention before moving forward with the PR: the expense Search snapshot doesn't return the inserted field on transactions at all, so the logic for ordering the "Recently added" widget could be simpler. For now, we read inserted from the local transactions collection and use created as a fallback.

I think we should create a follow up to add this property to the search on the backend.

cc: @grgia @JmillsExpensify

The hook falls back to the created date when an expense has no inserted
timestamp, so the test now expects the created-only expense to outrank
one with an earlier inserted timestamp.
@ZhenjaHorbach

ZhenjaHorbach commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-06-19.15.46.25.mov
Android: mWeb Chrome
2026-06-19.15.50.40.mov
iOS: HybridApp
2026-06-19.15.46.25.mov
iOS: mWeb Safari
2026-06-19.15.50.40.mov
MacOS: Chrome / Safari
2026-06-19.15.38.16.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

After opening the parent report and going back
The carousel buttons don't show

2026-06-19.15.46.50.mov

Opening a parent report in the same SEARCH_REPORT RHP overwrote and then
cleared the underlying transaction-thread carousel's active IDs, so the
prev/next carousel vanished on back-navigation. Save the carousel context
present underneath the report on mount and restore it on unmount instead
of unconditionally clearing.
@shawnborton

Copy link
Copy Markdown
Contributor

Yup, agree with Jason's comments above. I would love to standardize on this three dots icon menu pattern for any time we need to add more buttons/nav options to the parent level of a widget.

The previous overwrite-then-restore approach restored the Recently added
carousel IDs through an async Onyx write, so for one frame the prev/next
buttons reflected the parent report's transactions before settling. Instead,
the parent report's transaction list now leaves a descriptor-backed carousel
(the Recently added flow) untouched, so its IDs are never clobbered and there
is nothing to restore. Row presses still seed siblings lazily via
useNavigateToTransactionThread.
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach, The carousel problem should be fixed

Build a full Transaction via the test factory instead of an unsafe cast,
and switch mock helpers to jest.mocked to stay under the seatbelt budget.
@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

LGTM!

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

@adamgrzybowski
And can you please prepare a list of what we need to fix as a follow-up?

@melvin-bot melvin-bot Bot requested a review from grgia June 19, 2026 15:29
@grgia

grgia commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

#93451 (comment)

@adamgrzybowski tag me if you need any help making issues

@grgia grgia merged commit f5a9cbf into Expensify:main Jun 19, 2026
35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants