[No QA] fix: set iouRequestType in per diem inline edit tests#93600
Merged
Conversation
Per diem detection now relies on iouRequestType after PR #88289, so the TransactionInlineEdit tests need that field to match real transaction data. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@eh2077 no need to review. |
luacmartins
approved these changes
Jun 15, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
blimpich
approved these changes
Jun 15, 2026
Contributor
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
|
@puneetlath No QA Steps, OK to checkoff this one? |
Contributor
Author
|
Yes, it's just an update to tests. We can check it off. |
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per diem detection now relies on iouRequestType after PR #88289, so the TransactionInlineEdit tests need that field to match real transaction data.
Explanation of Change
Fixes broken jest tests on main.
Fixed Issues
$ #93597
Tests
Make sure jest tests pass.
Offline tests
n/a
QA Steps
n/a
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari