fix: iOS view of empty agent's empty state is broken#93636
Conversation
Modified the subtitle styling in AgentsPage to center-align the text and removed the deprecated agentsPageEmptyStateSubtitle style from the styles index.
|
🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Screenshots seem good to me 👍 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
fix: iOS view of empty agent's empty state is broken (cherry picked from commit 0c06f5e) (cherry-picked to staging by puneetlath)
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.8-1 🚀
|
|
🤖 Help site review: no changes required I reviewed the changes in this PR and no Expensify help site updates are needed. Why: This PR is a pure layout/CSS fix for the Agents page empty state on iOS. It only:
There are no changes to copy, feature behavior, navigation, settings labels, or user-facing functionality — nothing that any article under @NicolasBonet, if you disagree and believe a help site update is needed, let me know and I'll create the draft PR. |
|
Issue is not reproducible on iPhone 13 Mini/ iOS 26.5 in v9.4.8-2 93636.mp4 |
|
thanks! |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.9-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. I reviewed the changes in this PR. They are a purely visual/layout fix for the Agents page empty state on iOS — centering and constraining the subtitle text so it renders correctly:
No feature behavior, flows, settings, labels, or buttons changed — only how the existing empty state is laid out on a small screen. Help site articles under @NicolasBonet, since no help site changes were required, there is no linked help site PR to review. If you believe a docs update is warranted, reply with details and I'll create one. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.9-0 🚀
|
Explanation of Change
Fixes the empty state of agents in iOS
Fixed Issues
$ #93630
PROPOSAL: #93630
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari