Skip to content

Fix crashes when personal details are not available #9385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcaaron merged 9 commits into from
Jul 1, 2022
Merged

Fix crashes when personal details are not available #9385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dbd8656
Fix crash when personalDetails are missing
aldo-expensify Jun 9, 2022
07e0997
Show spinner when personal details are not available
aldo-expensify Jun 9, 2022
dea9de5
Merge branch 'aldo_test-proposed-solution' of github.com:Expensify/Ap…
aldo-expensify Jun 10, 2022
c379cc6
Fix import
aldo-expensify Jun 10, 2022
d47836b
Add isRequired to personalDetails prop
aldo-expensify Jun 10, 2022
7b1660c
Remove unnecessary check
aldo-expensify Jun 13, 2022
bb05c28
Find personal details when creating new chat
aldo-expensify Jun 21, 2022
dd87f7e
Merge branch 'main' of github.com:Expensify/App into aldo_fix-crash-m…
aldo-expensify Jun 21, 2022
1cc5eea
Replace ActivityIndicator by FullscreenLoadingIndicator
aldo-expensify Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,9 @@ function fetchOrCreateChatReport(participants, shouldNavigate = true) {
const simplifiedReportObject = getSimplifiedReportObject(data);
Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${data.reportID}`, simplifiedReportObject);

// Fetch the personal details if there are any
PersonalDetails.getFromReportParticipants([simplifiedReportObject]);

if (shouldNavigate) {
// Redirect the logged in person to the new report
Navigation.navigate(ROUTES.getReportRoute(data.reportID));
Expand Down
5 changes: 5 additions & 0 deletions src/pages/DetailsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import CONST from '../CONST';
import * as ReportUtils from '../libs/ReportUtils';
import DateUtils from '../libs/DateUtils';
import * as Expensicons from '../components/Icon/Expensicons';
import FullscreenLoadingIndicator from '../components/FullscreenLoadingIndicator';
import MenuItem from '../components/MenuItem';
import AttachmentModal from '../components/AttachmentModal';
import PressableWithoutFocus from '../components/PressableWithoutFocus';
Expand Down Expand Up @@ -66,6 +67,10 @@ const getPhoneNumber = (details) => {

const DetailsPage = (props) => {
const details = props.personalDetails[props.route.params.login];

@tgolen tgolen Jul 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this line is probably what is causing this crash: #9545

It doesn't seem like a very safe way to access properties. It appears like there can be cases where props.route.params is undefined. Is that a valid case? Should this use lodashGet instead?

@aldo-expensify aldo-expensify Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right. If you just open https://new.expensify.com/details without the param login, it crashes. I'll spin a small PR to fix it.

@aldo-expensify aldo-expensify Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this feels low priority, I don't know how a user ended up with the URL without the parameter.

if (!details) {
// Personal details have not loaded yet
return <FullscreenLoadingIndicator />;
}
const isSMSLogin = Str.isSMSLogin(details.login);

// If we have a reportID param this means that we
Expand Down