Skip to content

[No QA] Helpsite update walkthroughs#93887

Open
stephanieelliott wants to merge 4 commits into
mainfrom
helpsite-update-walkthroughs
Open

[No QA] Helpsite update walkthroughs#93887
stephanieelliott wants to merge 4 commits into
mainfrom
helpsite-update-walkthroughs

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@stephanieelliott stephanieelliott self-assigned this Jun 17, 2026
@github-actions github-actions Bot changed the title Helpsite update walkthroughs [No QA] Helpsite update walkthroughs Jun 17, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott marked this pull request as ready for review June 17, 2026 23:27
Comment thread docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md Outdated

**For Workspace Admins:**
- [nteractive web tour for Workspace Admins](https://expensify.storylane.io/share/qlgnexxbsdtp)
- [nteractive mobile tour for Workspace Admins](https://expensify.storylane.io/share/em54uaq7wbgk)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor text typo: "nteractive" should be "Interactive mobile tour for Workspace Admins". Fix the missing leading "I" for clear, searchable anchor text (HELP_AUTHORING_GUIDELINES Section 7).

Comment thread docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md Outdated
Comment thread docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md Outdated
Comment thread docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates interactive product tour links in two getting-started articles. In Coming-from-Expensify-Classic-for-Workspace-Admins.md it swaps a single mobile tour URL. In Navigating-New-Expensify.md it adds a new block of four interactive tour links (web/mobile for Workspace Admins and for submitters/approvers) plus a training-resources cross-link. The changes are small and additive, but the new block in the second file contains a repeated typo and some formatting inconsistencies that should be fixed before merge.

Scores Summary

  • Readability: 6/10 - The intent is clear, but every one of the four new link labels has a typo ("nteractive" instead of "Interactive"), and there are stray double blank lines, which hurts polish and scannability.
  • AI Readiness: 7/10 - Anchor text is descriptive and search-aligned (audience + platform), and the cross-link to training resources reinforces the workflow. No new headings or metadata were introduced, so those rules are unaffected. Minor deduction for the typo degrading anchor text.
  • Style Compliance: 6/10 - Inconsistent casing between the two group labels (**For Workspace Admins:** vs **For submitters and approvers:**); audience labels should be applied consistently. Full external URLs are used (Storylane), which conflicts with the relative-links rule, though these are external tools where a relative link is not possible and the existing file already uses the same pattern.

Key Findings

  • Typo repeated in all four new anchors in Navigating-New-Expensify.md: "nteractive" is missing the leading "I". This must be fixed.
  • Inconsistent capitalization between the two bold group labels ("Workspace Admins" vs "submitters and approvers").
  • Extra consecutive blank lines added after the new block.
  • Positive: anchor text is descriptive and follows real search phrasing (audience + platform), and adding the training-resources cross-link is a good, on-scope reinforcement.
  • Positive: the single URL swap in Coming-from-Expensify-Classic-for-Workspace-Admins.md is clean and introduces no issues.

Recommendations

  • Fix the "nteractive" to "Interactive" typo in all four new links.
  • Make the two group labels consistent in casing per the chosen convention.
  • Remove the extra blank line(s) after the tour block.
  • No action needed on the external Storylane URLs given there is no relative equivalent, but keep the relative-links rule in mind for internal references.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Coming-from-Expensify-Classic-for-Workspace-Admins.md - Clean single mobile tour URL update; no issues.
  • docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md - New tour links block; fix typo, label casing, and extra blank lines.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 19, 2026
stephanieelliott and others added 2 commits June 19, 2026 11:13
Resolve conflict from Transitioning-to-New-Expensify folder reorganization while preserving updated Storylane walkthrough URLs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@OSBotify

Copy link
Copy Markdown
Contributor

@stephanieelliott

Copy link
Copy Markdown
Contributor Author

Applied all relevant bot comments.

@stephanieelliott stephanieelliott requested a review from a team June 19, 2026 21:18
@melvin-bot

melvin-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @zanyrenney

@melvin-bot melvin-bot Bot requested review from zanyrenney and removed request for a team June 19, 2026 21:18
@melvin-bot

melvin-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants