[Home Page] Remove Getting started slot from Home whenever all onboarding to-dos are complete by adamgrzybowski · Pull Request #94047 · Expensify/App

adamgrzybowski · 2026-06-19T13:19:52Z

Explanation of Change

Previously the Getting started slot stayed on the Home page for the full 60-day onboarding window, even after a user had finished everything.
Now the section is hidden as soon as every onboarding to-do is complete, while the 60-day window remains an upper bound for users who still have outstanding to-dos.

Fixed Issues

$ #93106
PROPOSAL:

Tests

Offline tests

QA Steps

Sign up / log in with an account whose onboarding intent is Manage my team's expenses or Track my company's expenses and confirm the Getting started section appears on Home while at least one to-do is still incomplete.
Complete every to-do listed in the Getting started section.
Verify the Getting started section disappears from Home once all to-dos are complete, instead of lingering for the rest of the 60-day window.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-19.at.15.14.24.mov

…lete Previously the Getting started slot stayed on Home for the full 60-day window regardless of progress. Hide it as soon as every onboarding to-do is complete, while keeping the 60-day window as an upper bound.

melvin-bot · 2026-06-19T13:19:58Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-06-19T15:56:13Z

+    const buildResult = (builtItems: GettingStartedItem[]): UseGettingStartedItemsResult => {
+        if (builtItems.every((item) => item.isComplete)) {
+            return emptyResult;
+        }
+        return {shouldShowSection: true, items: builtItems};
+    };


@JmillsExpensify
If we fill out all the checkboxes, but then fail to meet the conditions of one of the fields (for example, delete a custom category and the category checkbox will reset), the Getting Started slot will return
Are we okay with that?

I think that's probably fine. Sounds like a bit of an edge case if you go to the effort of adding custom categories, just to delete them all to leave the defaults.

trjExpensify

Makes sense, nice improvement. 👍

ZhenjaHorbach · 2026-06-22T14:52:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-06-22.17.30.49.mov

Android: mWeb Chrome

2026-06-22.17.29.44.mov

iOS: HybridApp

2026-06-22.17.30.49.mov

iOS: mWeb Safari

2026-06-22.17.29.44.mov

MacOS: Chrome / Safari

2026-06-22.16.56.04.mov

ZhenjaHorbach · 2026-06-25T15:37:46Z

@grgia
Let's merge this!

OSBotify · 2026-06-26T12:54:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-26T12:55:23Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-26T13:00:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94047.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a0e38bc41a8-27a47d6-06048e2c665b2703fba72549cab52a8fe26622c0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a0e38bc-27a47d6-ee4d785f142bddcbfd4fe470126bb5db5e50b773/index.html

Web 🕸️
https://94047.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-26T20:00:24Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.21-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-06-27T11:09:43Z

This PR failing because of the issue #94773
This issue is reproducible in: All platforms

jponikarchuk · 2026-06-27T11:10:07Z

Deploy Blocker #94773 was identified to be related to this PR.

adamgrzybowski requested review from a team as code owners June 19, 2026 13:19

melvin-bot Bot assigned adamgrzybowski Jun 19, 2026

melvin-bot Bot requested review from ZhenjaHorbach and trjExpensify and removed request for a team June 19, 2026 13:19

melvin-bot Bot removed the request for review from a team June 19, 2026 13:19

ZhenjaHorbach reviewed Jun 19, 2026

View reviewed changes

trjExpensify approved these changes Jun 19, 2026

View reviewed changes

ZhenjaHorbach approved these changes Jun 22, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia June 22, 2026 15:32

grgia approved these changes Jun 26, 2026

View reviewed changes

grgia merged commit a0e38bc into Expensify:main Jun 26, 2026
36 of 39 checks passed

OSBotify mentioned this pull request Jun 26, 2026

Deploy Checklist: New Expensify 2026-06-26 #94730

Open

45 tasks

MelvinBot mentioned this pull request Jun 26, 2026

[No QA] Docs updates for E/A#94047 Hide Getting started when onboarding complete #94735

Draft

applause-bot Bot mentioned this pull request Jun 27, 2026

The "Getting started" section disappears from Home before all to-dos are complete #94773

Open

7 tasks

jponikarchuk mentioned this pull request Jun 27, 2026

[$250] Remove Getting started slot from Home whenever all onboarding to-dos are complete #93106

Open

Uh oh!

Conversation

adamgrzybowski commented Jun 19, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 19, 2026

Uh oh!

ZhenjaHorbach Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jun 25, 2026

Uh oh!

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

jponikarchuk commented Jun 27, 2026

Uh oh!

jponikarchuk commented Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ZhenjaHorbach commented Jun 22, 2026 •

edited

Loading