[No QA] Docs updates for E/A#93941 Workspace member role filter availability and reset#94067
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#93941 Workspace member role filter availability and reset#94067MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…set behavior Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
43 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://00b88dae.helpdot.pages.dev ⚡️ Updated articles: |
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
PR #93941 fixes the Workspace Members role filter so that when the currently-selected role is no longer an available option (for example, after the workspace plan changes and removes that role from the dropdown), the filter falls back to All members instead of staying stuck on a now-unavailable role.
The existing help article
Managing-Workspace-Members.mddocuments this filter but was out of date with the current UI. This docs update:Role labels and availability were verified against the source of truth in
src/languages/en.tsandsrc/pages/workspace/WorkspaceMembersPage.tsx.Fixed Issues
$ #93933
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
This is a HelpDot docs-only change. To validate, open Workspace settings > Members on a Submit workspace, confirm the filter shows Editors, then upgrade to Collect/Control and confirm the documented labels (Workspace Admins, Card Admins, Auditors) and the auto-reset to All members match the article.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveen.tsandWorkspaceMembersPage.tsx)Screenshots/Videos
N/A — documentation-only change.
@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.