Skip to content

Hide top-level required tag toggle for independent multi-level tags#94760

Open
MobileMage wants to merge 1 commit into
Expensify:mainfrom
MobileMage:fix/93731-required-toggle-multilevel-tags
Open

Hide top-level required tag toggle for independent multi-level tags#94760
MobileMage wants to merge 1 commit into
Expensify:mainfrom
MobileMage:fix/93731-required-toggle-multilevel-tags

Conversation

@MobileMage

Copy link
Copy Markdown
Contributor

Explanation of Change

On Workspace → Tags → Settings, the top-level "Members must tag all expenses" (requiresTag) toggle was shown for independent multi-level tags, where it should not appear — for independent multi-level tags the Required setting is configured per level inside each tag list's RHP, matching Expensify Classic. Per the agreed behavior in the issue:

  • Single-level tags: show the top-level Required toggle.
  • Dependent multi-level tags: show the top-level Required toggle (you can't require just one level in a dependent world).
  • Independent multi-level tags: do not show the top-level Required toggle; Required is set per level in each tag list's RHP.

This change gates the top-level toggle in WorkspaceTagsSettingsPage with (!isMultiLevelTags || hasDependentTags), using hasDependentTags from PolicyUtils. The per-level toggle on the individual tag-list page is already gated correctly and is left unchanged.

Fixed Issues

$ #93731
PROPOSAL: #93731 (comment)

Tests

Prerequisite: a Control-plan workspace as an admin, with Tags enabled. Creating multi-level tags requires importing a CSV spreadsheet.

  1. Single-level tags: with a single-level tag list, go to Workspace → Tags → More → Settings. Verify the "Members must tag all expenses" toggle is shown.
  2. Dependent multi-level tags: import a dependent multi-level tags CSV (child tags filtered by their parent). Go to Tags → Settings. Verify the "Members must tag all expenses" toggle is shown.
  3. Independent multi-level tags: import an independent multi-level tags CSV (two or more independent tag lists, e.g. Department + Region, with no parent filter). Go to Tags → Settings. Verify the "Members must tag all expenses" toggle is not shown (only "Track billable expenses" remains).
  4. From the independent multi-level Tags list, open an individual tag list and verify the Required toggle is available there, per level.
  • Verify that no errors appear in the JS console

Offline tests

  1. Open Workspace → Tags → Settings for an independent multi-level tags workspace while online and confirm the Required toggle is hidden.
  2. Turn off your network connection.
  3. Reopen the Settings page and verify the toggle visibility is identical (the gate is purely client-side and does not depend on network state).
  • Verify that no errors appear in the JS console

QA Steps

On staging as an admin on a Control-plan workspace with Tags enabled:

  1. With single-level tags, open Tags → Settings and verify the "Members must tag all expenses" toggle is shown.
  2. Import dependent multi-level tags, open Tags → Settings, and verify the toggle is shown.
  3. Import independent multi-level tags, open Tags → Settings, and verify the toggle is not shown; confirm Required can still be set per level in each tag list's RHP.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Kapture.2026-06-27.at.06.15.09.mp4
Android: mWeb Chrome
iOS: Native
Kapture.2026-06-26.at.20.29.18.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Kapture.2026-06-25.at.15.39.52.mp4

@MobileMage MobileMage requested review from a team as code owners June 27, 2026 05:30
@melvin-bot melvin-bot Bot requested review from a team, Eskalifer1 and trjExpensify and removed request for a team June 27, 2026 05:31
@melvin-bot

melvin-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from flaviadefaria and removed request for a team June 27, 2026 05:31
@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...pages/workspace/tags/WorkspaceTagsSettingsPage.tsx 0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f67aec50d9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

/>
</OfflineWithFeedback>
)}
{(!isMultiLevelTags || hasDependentTags) && (

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep global required flag clearable for independent tags

When an independent multi-level workspace already has policy.requiresTag === true (for example from the previously visible switch, or from the Rules require-fields flow which still calls setPolicyRequiresTag in src/pages/workspace/rules/RulesRequireFieldsPage.tsx:82-83), hiding this row leaves that global flag active while users only see per-list Required switches. The expense flow still ORs each list's required with policy.requiresTag in getTagVisibility (src/libs/TagsOptionsListUtils.ts:215-216) and violation recalculation still treats policy.requiresTag as requiring tags (src/libs/Violations/ViolationsUtils.ts:457-463), so every independent level can remain required even after the visible per-level switches are off; please clear/ignore the global flag for independent tags, or keep this control visible while it is on.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant