Add specific error messages for additional details page by thesahindia · Pull Request #9495 · Expensify/App

thesahindia · 2022-06-20T13:31:21Z

Details

This PR will add specific error message for different fields at additional details page.

Fixed Issues

$ #9247

Tests

I changed the component here to EnablePaymentsPage to render the additional details page(now you can just tap on your avatar and it will render the additional details page)

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.js

Line 179 in 2ec4a1c

Component: SettingsInitialPage,
Try to submit the form without filling any field
Verify you see specific error messages, e.g. Please enter a valid xyz

At dob try using current date and submit
Verify you see an error message (Must be over 18 years old)

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Click on Fab icon > send money > onfido verification > Additional details page
Try to submit the form without filling any field
Verify you see specific error messages, e.g. Please enter a valid xyz

At dob try using current date and submit
Verify you see an error message (Must be over 18 years old)

Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

…x-error-message merge main

mananjadhav

Changes look good and also test well. One request, @thesahindia Is it possible to get a minDate on the date picker?

Also can you check mark every item on the list in GH body (even if they don't apply) to confirm that we've checked those.

mananjadhav · 2022-07-03T22:23:34Z

                                    containerStyles={[styles.mt4]}
                                    label={this.props.translate(this.fieldNameTranslationKeys.dob)}
-                                    onInputChange={val => this.clearErrorAndSetValue('dob', val)}
+                                    onInputChange={val => this.clearDateErrorsAndSetValue(val)}


Were you able to test this on iOS Safari? I get a different date format and unable to move forward.

~~I just tested this again and it shows Must be over 18~~
Oh NVM, you have added a future date that's why the error is different.

I get a different date format and unable to move forward.

Yeah we have a different format on native.

thesahindia · 2022-07-04T16:44:01Z

Changes look good and also test well. One request, @thesahindia Is it possible to get a minDate on the date picker?

We have maximumDate which stops user from choosing future dates but it only works for Web/Desktop

Also can you check mark every item on the list in GH body (even if they don't apply) to confirm that we've checked those.

Done.

mananjadhav · 2022-07-05T19:02:28Z

Changes look good and also test well. One request, @thesahindia Is it possible to get a minDate on the date picker?

We have maximumDate which stops user from choosing future dates but it only works for Web/Desktop

No I meant minimumDate, which can be applied so that DatePicker doesn't allow you to select those dates.

thesahindia · 2022-07-07T17:25:12Z

No I meant minimumDate, which can be applied so that DatePicker doesn't allow you to select those dates.

I am not really sure but I guess we can do that. Also can you please provide some context about how we wanna use it?
Also this looks out of scope for this issue.

mananjadhav · 2022-07-08T18:36:34Z

You're right this could be out of the scope of this issue. I thought if its a prop available we can just set it.

mananjadhav · 2022-07-08T18:39:56Z

@AndrewGable Review done

🎀 👀 🎀 C+ reviewed

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

AndrewGable · 2022-07-08T22:54:19Z

Nice work on filling out the checklists!

OSBotify · 2022-07-08T23:00:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-07-12T21:34:05Z

🚀 Deployed to staging by @AndrewGable in version: 1.1.83-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-07-20T22:27:41Z

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2022-08-10T21:30:50Z

@mananjadhav @thesahindia do you think #10240 is a regression from this PR?

thesahindia added 2 commits June 20, 2022 17:11

add specific error messages

18798c3

show error when the user isn't 18

5945666

thesahindia requested a review from a team as a code owner June 20, 2022 13:31

melvin-bot Bot requested review from AndrewGable and mananjadhav and removed request for a team June 20, 2022 13:31

thesahindia marked this pull request as draft June 20, 2022 13:31

thesahindia added 3 commits June 28, 2022 20:40

Merge branch 'main' of github.com:thesahindia/App into thesahindia/fi…

ed6fbb8

…x-error-message merge main

add specific error for full ssn

abc97ab

handle undefined value for phone number

35454e1

thesahindia marked this pull request as ready for review June 28, 2022 16:49

mananjadhav suggested changes Jul 3, 2022

View reviewed changes

mananjadhav reviewed Jul 3, 2022

View reviewed changes

AndrewGable approved these changes Jul 8, 2022

View reviewed changes

AndrewGable merged commit 3ee772b into Expensify:main Jul 8, 2022

OSBotify mentioned this pull request Jul 12, 2022

Deploy Checklist: New Expensify 2022-07-12 #9847

Closed

95 tasks

melvin-bot Bot mentioned this pull request Jul 18, 2022

[HOLD for payment 2022-07-25] [$250] At additional details page the error messages aren't correct - reported by @thesahindia #9247

Closed

Conversation

thesahindia commented Jun 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

mananjadhav left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jul 3, 2022

Choose a reason for hiding this comment

Uh oh!

thesahindia Jul 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thesahindia commented Jul 4, 2022

Uh oh!

mananjadhav commented Jul 5, 2022

Uh oh!

thesahindia commented Jul 7, 2022

Uh oh!

mananjadhav commented Jul 8, 2022

Uh oh!

mananjadhav commented Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Checklist

Uh oh!

AndrewGable commented Jul 8, 2022

Uh oh!

OSBotify commented Jul 8, 2022

Uh oh!

OSBotify commented Jul 12, 2022

Uh oh!

OSBotify commented Jul 20, 2022

Uh oh!

rushatgabhane commented Aug 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thesahindia commented Jun 20, 2022 •

edited

Loading

mananjadhav left a comment •

edited

Loading

thesahindia Jul 4, 2022 •

edited

Loading

mananjadhav commented Jul 8, 2022 •

edited

Loading