[No QA] add new help site project#9519
Conversation
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
…marco-addNewHelpSite
|
Hi @roryabraham, update: I addressed the request changes and added a few responses in some comments, thank you for reviewing again! |
roryabraham
left a comment
roryabraham
left a comment
There was a problem hiding this comment.
The only remaining blocker for me is moving the script tags to the <head> tag. We can clean up the scss further in a follow-up.
|
Created a follow-up PR as a first step to help set up some better sass practices: #9687 |
roryabraham
left a comment
roryabraham
left a comment
There was a problem hiding this comment.
I also noticed that the README.md and TEMPLATE.md are included in the generated site, but we don't need them to be bundled. To fix that, add this to _config.yml:
exclude: [README.md, TEMPLATE.md]
Cool, added |
|
Update: moved the scripts to the |
|
Merging since @PauloGasparSv approved before and @yuwenmemon is OOO |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @roryabraham in version: 1.1.81-0 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀
|
4 participants
cc @roryabraham
Details
This PR adds the base project for the new Expensify Help site in the
helpfolder of the App repo. It already contains some important features described in the doc and the current state of the project allows us to begin to add articles as Markdown files.We're going to be adding more features to this project.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/216729
Tests
N/A