[No QA] update JSDoc for API.js functions#9558
Merged
Merged
Conversation
madmax330
reviewed
Jun 24, 2022
madmax330
left a comment
madmax330
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just some small comments
tgolen
previously requested changes
Jun 24, 2022
Co-authored-by: Tim Golen <tgolen@gmail.com>
Co-authored-by: Tim Golen <tgolen@gmail.com>
Co-authored-by: Tim Golen <tgolen@gmail.com>
Co-authored-by: Tim Golen <tgolen@gmail.com>
Co-authored-by: Tim Golen <tgolen@gmail.com>
Co-authored-by: Tim Golen <tgolen@gmail.com>
Co-authored-by: Tim Golen <tgolen@gmail.com>
Contributor
Author
|
Cool, thanks for the suggestions! I updated again the JSDoc of the API.js functions |
tgolen
previously approved these changes
Jun 24, 2022
marcaaron
previously approved these changes
Jun 24, 2022
aldo-expensify
previously requested changes
Jun 24, 2022
aldo-expensify
left a comment
aldo-expensify
left a comment
Contributor
There was a problem hiding this comment.
Just a small thing!
aldo-expensify
previously approved these changes
Jun 24, 2022
aldo-expensify
previously approved these changes
Jun 24, 2022
AndrewGable
previously approved these changes
Jun 24, 2022
AndrewGable
left a comment
AndrewGable
left a comment
Contributor
There was a problem hiding this comment.
Looks good! One suggestion.
Co-authored-by: Andrew Gable <andrew@expensify.com>
aldo-expensify
approved these changes
Jun 24, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
71 tasks
Contributor
|
🚀 Deployed to staging by @marcochavezf in version: 1.1.79-0 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @aldo-expensify @tgolen
Details
Coming from this comment #9536 (comment), this PR adds JSDoc description and function signatures to the API.js functions.
Fixed Issues
N/A
Tests
N/A
PR Review Checklist
N/A
QA Steps
N/A