[No QA] Update PR template to be more explicit about expectations to check off everything#9698
Merged
Conversation
flodnv
requested review from
iwiznia,
mallenexpensify,
mananjadhav,
parasharrajat,
puneetlath and
sketchydroide
flodnv
commented
Jul 5, 2022
| - [ ] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/docs/STYLE.md#jsdocs)) were followed | ||
| - [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers | ||
| - [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/docs/PR_REVIEW_GUIDELINES.md) | ||
| - [ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` have been tested & I retested again) |
chiragsalian
reviewed
Jul 5, 2022
iwiznia
previously approved these changes
Jul 5, 2022
sketchydroide
previously approved these changes
Jul 5, 2022
puneetlath
previously approved these changes
Jul 5, 2022
flodnv
dismissed stale reviews from puneetlath, sketchydroide, and iwiznia
via
4cc0226
puneetlath
approved these changes
Jul 8, 2022
chiragsalian
approved these changes
Jul 8, 2022
Contributor
|
Going to merge since most of the people approved before and the most recent update was a minor change. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
roryabraham
changed the title
Contributor
|
🚀 Deployed to staging by @chiragsalian in version: 1.1.83-1 🚀
|
Contributor
|
🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Redo of #9597
I have seen some confusions, hopefully this clears them up.
cc @Expensify/contributor-plus
Fixed Issues
https://expensify.slack.com/archives/C01SKUP7QR0/p1655892677571859
Tests
none needed
PR Review Checklist
this is what I am modifying
QA Steps
N/A