[No QA] add "coming soon" page to Expensify Help site#9869
Merged
Conversation
|
I think you'll need to merge |
Contributor
Author
yup, merged main, PR ready to be reviewed |
ctkochan22
approved these changes
Jul 13, 2022
95 tasks
Contributor
|
🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOLD ON #9765cc @roryabraham @michelle-thompson
Details
This PR replaces the main page with a "coming soon" page. We're going to replace it again with the main page once we upload more content to the Expensify Help site.
Also this PR is branched off from #9765. Once #9765 is merged I'm going to merge main into this branch and the real number of commits will be displayed.
Fixed Issues
$ #9830
Tests
(you need ruby and bundler installed to do this, more info here)
Run:
Make sure the "coming soon" page is displayed in the root directory (index.html).
Verify you can access the main site by visiting http://localhost:4000/main (atm the content area of the main page is empty, it just displays the LHN).
Screenshots
Web
Mobile Web