Skip to content

Add 'OpenIOUDetailsPage' API command #9878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 5 commits into from
Jul 18, 2022
Merged

Add 'OpenIOUDetailsPage' API command #9878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3db577e
add API read command
Julesssss Jul 13, 2022
42a2c61
Merge branch 'main' into jules-implementOpenIOUDetailsPageAPI
Julesssss Jul 13, 2022
4171bcb
implement new openPaymentDetailsPage API
Julesssss Jul 14, 2022
203abd9
add function doc
Julesssss Jul 14, 2022
494aed4
Merge branch 'main' into jules-implementOpenIOUDetailsPageAPI
Julesssss Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,6 +1132,19 @@ function openReport(reportID) {
});
}

/**
* Gets the IOUReport and the associated report actions.

@mountiny mountiny Jul 18, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB:

Suggested change
* Gets the IOUReport and the associated report actions.
* Gets the IOUReport and its associated report actions.

*
* @param {Number} chatReportID
* @param {Number} iouReportID
*/
function openPaymentDetailsPage(chatReportID, iouReportID) {
API.read('OpenPaymentDetailsPage', {
reportID: chatReportID,
iouReportID,
});
}

/**
* Marks the new report actions as read
*
Expand Down Expand Up @@ -1649,4 +1662,5 @@ export {
markCommentAsUnread,
readNewestAction,
openReport,
openPaymentDetailsPage,
};
2 changes: 1 addition & 1 deletion src/pages/iou/IOUDetailsModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class IOUDetailsModal extends Component {
}

fetchData() {
Report.fetchIOUReportByID(this.props.route.params.iouReportID, this.props.route.params.chatReportID, true);
Report.openPaymentDetailsPage(this.props.route.params.chatReportID, this.props.route.params.iouReportID);
}

/**
Expand Down