Fix crash when accessing bad method in ReportActionsView#9886
Merged
Conversation
Contributor
|
|
Contributor
|
Self assigning to get this through quickly. Sorry I missed this in the initial review. |
neil-marcellini
approved these changes
Jul 13, 2022
neil-marcellini
left a comment
Contributor
There was a problem hiding this comment.
This fixes the problem, thanks.
OSBotify
pushed a commit
that referenced
this pull request
Jul 13, 2022
Fix crash when accessing bad method in `ReportActionsView` (cherry picked from commit a6257d3)
OSBotify
added a commit
that referenced
this pull request
Jul 13, 2022
…9886 🍒 Cherry pick PR #9886 to staging 🍒
95 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Spotted this bug I introduced on
mainwhile testing some other stuff. The issue is on staging so we should CP this.cc @neil-marcellini
Fixed Issues
No Issue related to -> #9755
Tests
PR Review Checklist
PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)QA Steps