[No QA] Remove broken defaultProps#9890
Merged
Merged
Conversation
amyevans
approved these changes
Jul 14, 2022
amyevans
left a comment
amyevans
left a comment
Contributor
There was a problem hiding this comment.
Alternatively you could set a defaultProp for selectedCurrencyCode on , but it's kinda 🥔 🥔
PauloGasparSv
approved these changes
Jul 14, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
79 tasks
Contributor
|
🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Removes broken default props from IOUAmountPage. If any key in
props.iouis returned, the defaultProps for iou doesn't actually check thatiou.selectedCurrencyCodeis set, which makes it useless.cc @mountiny @PauloGasparSv
Fixed Issues
$ #9889
Tests
+ > Request moneyUSDcurrency