[No QA] Fetch tags before updating StagingDeployCash#9901
Merged
Conversation
francoisl
approved these changes
Jul 13, 2022
francoisl
left a comment
francoisl
left a comment
Contributor
There was a problem hiding this comment.
Reviewing and merging as discussed in #deployers to attempt to unbreak deploys.
95 tasks
Contributor
|
🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
I am looking at recent changes and noticed we removed this
fetch-depth: 0: https://github.com/Expensify/App/pull/9812/files#diff-1219dd7a2951518446d9e9da907af2e02968bce34c2d2adda8ee4357bf22fa0cL87, which seems like a likely culprit for why our Git history would be messed upFixed Issues
$ n/a – broken deploys https://github.com/Expensify/App/runs/7330727826?check_suite_focus=true
Tests