[Snyk] Security upgrade moment from 2.29.1 to 2.29.4#9916
Merged
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MOMENT-2944238
melvin-bot
Bot
requested review from
MonilBhavsar
and removed request for
a team
flodnv
commented
Jul 14, 2022
Contributor
|
you've got some tests failing. Can you update with main? |
…443e351a45297687dddd
Contributor
Author
|
I have merged main, and looked at the failing GH action, and so I ran |
Contributor
|
Weird ... maybe this is a hint?
Unmet dependency |
Contributor
|
@flodnv I was able to get the diff locally by doing a clean install from the App directory: npm list moment # you'll see unmet moment dependency
rm -rf node_modules && npm i # clean install
npm list moment # you'll now see that the dependency is met
npm run gh-actions-build # you'll now see the diff |
Contributor
Author
|
Many thanks @roryabraham ! Updated, ready for final review @chiragsalian |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
79 tasks
Contributor
|
🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are only bug fixes being brought in so we should be fine: https://github.com/moment/moment/blob/HEAD/CHANGELOG.md
$ https://github.com/Expensify/Expensify/issues/218289
$ https://github.com/Expensify/Expensify/issues/218321
This PR was automatically created by Snyk using the credentials of a real user.
Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.5
SNYK-JS-MOMENT-2944238
(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.