[NoQA] fix links for Expensify Help site#9925
Merged
Merged
Conversation
johnmlee101
approved these changes
Jul 15, 2022
Contributor
|
Why can't this be QA'd? |
Contributor
Author
Ah the site is still in an "alpha" version and we're going to still do more changes, but this fix is required for us to internally begin to upload content. So I think it won't make sense to use QA since we're going to be testing the site internally until we have more content :) |
Contributor
Author
|
Merging it |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
I don't necessarily agree. As long as one of the QA testers can jump into the site and click the links I think its fine to have it go through the QA process since its not being cherry-picked. |
79 tasks
Contributor
|
🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes the links for the new Expensify Help (where the back button is not working as expected here).
Fixed Issues
N/A
Tests
(you need ruby and bundler installed to do this, more info here)
Run:
Navigate to http://localhost:4000/articles/request-money/SmartScan and click on the
Backbutton, it should redirect to the hub page (upper level)Homebutton and verify it redirects you to the Homepage (currently it's an empty page) instead of the "Coming soon" page.