New Rules added to HTML to markdown parsing [bold, italic, Strikethrough]#392
Merged
Conversation
This was referenced Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Jag96 Will you please review this?
[Explanation of the change or anything fishy that is going on]
Fixed Issues
$ Expensify/App#3970
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
Covered with Jest Unit tests
What tests did you perform that validates your changed worked?
I used the changes here to E.cash repo to try pasting HTML strings in Composer
QA
What does QA need to do to validate your changes?
After these changes are merged to E.cash, you can try copy-pasting formatted String to Composer. Otherwise, add more unit Tests and test them.
What areas do they need to test for regressions?
Check HTML to markdown parsing of Expensimark