Changed <br> to <br /> as line break to solve the issue "Saving without editing the multiline comments edit box shows [Comment Deleted] in LHN"

[sobitneupane]

@puneetlath @rushatgabhane will you please review this?

This change is made to solve the issue "Saving without editing the multiline comments edit box shows [Comment Deleted] in LHN"

Reason:
In editReportComment in Report.js, we are using ExpensiMark as the parser and ExpensiMark uses <br> as the line break. But the originalReportAction.message[0].html has <br /> as the line break. So, two messages when compared appear different and it is considered to be edited. So, though the message is not edited, the message is indicated as an edited message. Problem begins here.

Fixed Issues

$ Expensify/App#7268

Tests

1. Send multiline message.
2. Click on edit to edit the message. Save without editing
3. Nothing happens to lastMessageText in LHN. Previously, lastMessageText was changed to [Comment Deleted]

QA

1. Send multiline message.
2. Click on edit to edit the message. Save without editing
3. Nothing happens to lastMessageText in LHN. Previously, lastMessageText was changed to [Comment Deleted]

Web

comment_deleted.mp4

mWeb

vidma_recorder_edited_28012022_232927.mp4

Android

vidma_recorder_edited_28012022_225407.mp4

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[sobitneupane]

I have read the CLA Document and I hereby sign the CLA

[puneetlath]

@sobitneupane can you please test your change on all platforms and post screenshots from each? Thanks!

[sobitneupane]

@sobitneupane can you please test your change on all platforms and post screenshots from each? Thanks!

@puneetlath I have attached screen captured for Web, mWeb and Android. I don't have IOS and MacOS.

[Luke9389]

Hey @sobitneupane, a few things.

1. Can you change the title of this PR to describe the change you've made? Upon reading the title, there's no way to know what fix/issue is being addressed here.
2. Can you add detailed instructions for how someone else should test this change? Break it down step by step.

[rushatgabhane]

@sobitneupane Looks like we need to change the tests as well.

[rushatgabhane]

I don't have IOS and MacOS

I'll send those in a while

[sobitneupane]

Hey @sobitneupane, a few things.

1. Can you change the title of this PR to describe the change you've made? Upon reading the title, there's no way to know what fix/issue is being addressed here.
2. Can you add detailed instructions for how someone else should test this change? Break it down step by step.

Updated.

[sobitneupane]

@sobitneupane Looks like we need to change the tests as well.

Changed.

[rushatgabhane]

LGTM 🎉 Tests well on all platforms.

cc: @Luke9389 ? 😂

[rushatgabhane]

1. In /node_modules/expensify-common/lib/ExpensiMark.js, change <br> to <br />

@sobitneupane could you please remove this step from Tests and QA? Thanks

[Luke9389]

Will this affect ordinary messages as well as edited ones? Have we tested what this does in the "normal" situation of ppl sending each other messages?

[Luke9389]

I ask bc the tests in the OP only mention editing an already-sent message

[rushatgabhane]

Good question. I've looked into this here - Expensify/App#7268 (comment)

Basically, even if we pass Line1<br>Line2 to the API, the server returns Line1<br />Line2, and that's what is stored in Onyx.

I couldn't find any side effects that'll occur after implementing this change. I can't speak of any unrelated internal repos that use Expensimark.replace() though

[Luke9389]

awesome, thx @rushatgabhane

[puneetlath]

I just want to check, did we do this? If not, I can create a PR to do so:

[rushatgabhane]

Forgive me!

Yes please, let's create a PR to deploy expensify-common change to Expensify/App.

[rushatgabhane]

Created a PR ^