Skip to content

Avoid duplicate empty line when converting header1 markdown to html#472

Merged
joelbettner merged 2 commits into
mainfrom
cristi_avoid-duplicate-endline-when-header1
Nov 14, 2022
Merged

Avoid duplicate empty line when converting header1 markdown to html#472
joelbettner merged 2 commits into
mainfrom
cristi_avoid-duplicate-endline-when-header1

Conversation

@cristipaval

@cristipaval cristipaval commented Nov 9, 2022

Copy link
Copy Markdown
Contributor

<h1> tags break the line anyway, there is no need to add a <br /> when converting # markdown to html. This is needed to make header1 look nicer.

Fixed Issues

https://github.com/Expensify/Expensify/issues/238874

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  • there are automated tests added which check that the markdown converts to html as expected.
  1. What tests did you perform that validates your changes worked?
  • Link the expensify-common local repository by following these steps
  • Run the app
  • Open any chat and send a custom subject message like following:
    # Custom subject
    The message body
  • Check that there is no empty lines between the header and the message body

Screenshot 2022-11-10 at 00 00 12

QA

  1. What does QA need to do to validate your changes?
  • Run the app
  • Open any chat and send a custom subject message like following:
    # Custom subject
    The message body
  • Check that there is no empty lines between the header and the message body

Screenshot 2022-11-10 at 00 00 12

@cristipaval cristipaval requested a review from a team as a code owner November 9, 2022 22:19
@cristipaval cristipaval self-assigned this Nov 9, 2022
@melvin-bot melvin-bot Bot requested review from joelbettner and removed request for a team November 9, 2022 22:19
@cristipaval

Copy link
Copy Markdown
Contributor Author

bump @joelbettner

@joelbettner joelbettner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@joelbettner joelbettner merged commit dd66d93 into main Nov 14, 2022
@joelbettner joelbettner deleted the cristi_avoid-duplicate-endline-when-header1 branch November 14, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants