Add emoji rule#664
Merged
Merged
Conversation
Contributor
|
Please don't merge this PR and for testing, point app PR to the commit hash of this branch. |
Beamanator
requested review from
stitesExpensify
and removed request for
Beamanator
Contributor
|
@stitesExpensify assigning you since you're assigned to the issue |
Contributor
|
Thanks! |
50 tasks
stitesExpensify
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ Expensify/App#34307
Tests
htmlof the message and verify that the emoji is wrapped in aemojitagQA
htmlof the message and verify that the emoji is wrapped in aemojitagOffline test
Same as above
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop