Skip to content

Fix scroll on enter#220

Merged
BartoszGrajdek merged 2 commits into
mainfrom
@BartoszGrajdek/fix-scroll-on-enter
Mar 12, 2024
Merged

Fix scroll on enter#220
BartoszGrajdek merged 2 commits into
mainfrom
@BartoszGrajdek/fix-scroll-on-enter

Conversation

@BartoszGrajdek

Copy link
Copy Markdown
Contributor

Details

This PR fix the problem with input not scrolling into view the cursor after entering the new line using Enter or Shift + Enter

Related Issues

GH_LINK

Manual Tests

  1. Set static input height
  2. Add some text so you can scroll text inside markdown input
  3. On the end of the input start entering newlines. Verify on all browsers if input is scrolling down so the cursor in newline is fully visible

Linked PRs

@Skalakid

Copy link
Copy Markdown
Contributor

Good job, it works in most cases. I found only one bug but I think to solve it we should just change numbers in if statement:

Screen.Recording.2024-03-12.at.09.09.00.mov

@BartoszGrajdek

Copy link
Copy Markdown
Contributor Author

Adding this as a separate issue ^

@BartoszGrajdek BartoszGrajdek merged commit 7e2002f into main Mar 12, 2024
@BartoszGrajdek BartoszGrajdek deleted the @BartoszGrajdek/fix-scroll-on-enter branch March 12, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants