Skip to content

Bump expensify-common to 2.0.46 and fix handling br tag #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomekzaw merged 1 commit into from
Jul 16, 2024
+47 −28
Merged

Bump expensify-common to 2.0.46 and fix handling br tag #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions parser/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,15 @@ describe('email with same label as address', () => {
});
});

test('email with multiline hyperlinks', () => {
expect('[test\ntest](test@test.com)').toBeParsedAs([
{type: 'syntax', start: 0, length: 1},
{type: 'syntax', start: 10, length: 2},
{type: 'link', start: 12, length: 13},
{type: 'syntax', start: 25, length: 1},
]);
});

test('inline code', () => {
expect('Hello `world`!').toBeParsedAs([
{type: 'syntax', start: 6, length: 1},
Expand Down
2 changes: 2 additions & 0 deletions parser/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ function parseTreeToTextAndRanges(tree: StackItem): [string, Range[]] {
} else if (node.tag === '<h1>') {
appendSyntax('# ');
addChildrenWithStyle(node, 'h1');
} else if (node.tag === '<br />') {
text += '\n';
} else if (node.tag.startsWith('<pre')) {
appendSyntax('```');
const content = node.children.join('').replaceAll('&#32;', ' ');
Expand Down
2 changes: 1 addition & 1 deletion parser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"typescript": "^5.3.3"
},
"dependencies": {
"expensify-common": "2.0.35"
"expensify-common": "2.0.46"
}
}
41 changes: 21 additions & 20 deletions parser/react-native-live-markdown-parser.js
View file
Open in desktop

Large diffs are not rendered by default.

21 changes: 14 additions & 7 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2647,7 +2647,7 @@ __metadata:
"@types/underscore": ^1.11.15
esbuild: 0.19.4
esbuild-plugin-tsc: ^0.4.0
expensify-common: 2.0.35
expensify-common: 2.0.46
jest: ^29.7.0
typescript: ^5.3.3
languageName: unknown
Expand Down Expand Up @@ -9967,9 +9967,9 @@ __metadata:
languageName: node
linkType: hard

"expensify-common@npm:2.0.35":
version: 2.0.35
resolution: "expensify-common@npm:2.0.35"
"expensify-common@npm:2.0.46":
version: 2.0.46
resolution: "expensify-common@npm:2.0.46"
dependencies:
awesome-phonenumber: ^5.4.0
classnames: 2.5.0
Expand All @@ -9983,8 +9983,8 @@ __metadata:
react-dom: 16.12.0
semver: ^7.6.2
simply-deferred: "git+https://github.com/Expensify/simply-deferred.git#77a08a95754660c7bd6e0b6979fdf84e8e831bf5"
ua-parser-js: ^1.0.37
checksum: eeceea5fc03849c95af12c04a29c5c97a89a61e4714cdfc401ea5f15e8a4284557c5b77e5cbb77c0f0905a6e9d608f3b4e079ba310f32188a0ff4d2ad356a5b5
ua-parser-js: ^1.0.38
checksum: f2dd73ac10efc9c8cf512c810c3e07a3a865c1af4dc7742e07449a06ac1d91e4583dff15f79567bbd48e8f6c11ea10f20dd46c680d8f450b960799a881d44115
languageName: node
linkType: hard

Expand Down Expand Up @@ -19801,13 +19801,20 @@ __metadata:
languageName: node
linkType: hard

"ua-parser-js@npm:^1.0.35, ua-parser-js@npm:^1.0.37":
"ua-parser-js@npm:^1.0.35":
version: 1.0.37
resolution: "ua-parser-js@npm:1.0.37"
checksum: 4d481c720d523366d7762dc8a46a1b58967d979aacf786f9ceceb1cd767de069f64a4bdffb63956294f1c0696eb465ddb950f28ba90571709e33521b4bd75e07
languageName: node
linkType: hard

"ua-parser-js@npm:^1.0.38":
version: 1.0.38
resolution: "ua-parser-js@npm:1.0.38"
checksum: d0772b22b027338d806ab17d1ac2896ee7485bdf9217c526028159f3cd6bb10272bb18f6196d2f94dde83e3b36dc9d2533daf08a414764f6f4f1844842383838
languageName: node
linkType: hard

"uglify-js@npm:^3.1.4":
version: 3.17.4
resolution: "uglify-js@npm:3.17.4"
Expand Down