Skip to content

Throw and do not evict storage when bad data is set to Onyx #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gonals merged 2 commits into from
Jan 21, 2022
Merged

Throw and do not evict storage when bad data is set to Onyx #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0e25bc
Throw and do not evict storage when bad data is set to Onyx
marcaaron Jan 20, 2022
793fce8
prevent accessing message on undefined error
marcaaron Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Onyx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,11 @@ function remove(key) {
function evictStorageAndRetry(error, onyxMethod, ...args) {
logInfo(`Handled error: ${error}`);

if (error && Str.startsWith(error.message, 'Failed to execute \'put\' on \'IDBObjectStore\'')) {
logAlert('Attempted to set invalid data set in Onyx. Please ensure all data is serializable.');
throw error;
}

// Find the first key that we can remove that has no subscribers in our blocklist
const keyForRemoval = _.find(recentlyAccessedKeys, key => !evictionBlocklist[key]);

Expand Down