feat: add config option to disable sync events for some keys#124
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
recheck |
Contributor
Author
|
@marcaaron Based on your suggestion Expensify/App#8227 (comment) I drafted this pr. I am new in this repository. Could you please confirm, we need unit test for this pr? |
marcaaron
reviewed
Apr 15, 2022
marcaaron
left a comment
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
This LGTM. We'd have a hard time writing an automated test here as we need the storage event to be mocked somehow. Manual tests should be fine.
Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
@mdneyazahmad can you please do the following...
Thanks! |
Contributor
Author
|
@marcaaron updated |
89 tasks
marcaaron
approved these changes
Apr 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When user opens multiple tabs with different reports. We do not want some data in onyx to sync across tabs. This pr will add a feature that we can configure keys for which we do not want to subscribe to data change.
Related Issues
#127
Automated Tests
We'd have a hard time writing an automated test here as we need the storage event to be mocked somehow.
Linked PRs
Expensify/App#8759