Skip to content

Make onyx method mergeCollection lowercase #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Jul 14, 2022
Merged

Make onyx method mergeCollection lowercase #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a2b82
make onyx method mergeCollection lowercase
Julesssss Jul 14, 2022
38615e8
update test case
Julesssss Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Onyx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ function mergeCollection(collectionKey, collection) {
function update(data) {
// First, validate the Onyx object is in the format we expect
_.each(data, ({onyxMethod, key}) => {
if (!_.contains(['clear', 'set', 'merge', 'mergeCollection'], onyxMethod)) {
if (!_.contains(['clear', 'set', 'merge', 'mergecollection'], onyxMethod)) {
throw new Error(`Invalid onyxMethod ${onyxMethod} in Onyx update.`);
}
if (onyxMethod !== 'clear' && !_.isString(key)) {
Expand All @@ -833,7 +833,7 @@ function update(data) {
case 'merge':
merge(key, value);
break;
case 'mergeCollection':
case 'mergecollection':
mergeCollection(key, value);
break;
case 'clear':
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/onyxTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ describe('Onyx', () => {
// WHEN we pass a mergeCollection data object to Onyx.update
Onyx.update([
{
onyxMethod: 'mergeCollection',
onyxMethod: 'mergecollection',
key: ONYX_KEYS.COLLECTION.TEST_KEY,
value: {
test_1: {
Expand Down