Add waitForCollectionCallback param to Onyx.connect#163
Merged
Conversation
93 tasks
tgolen
approved these changes
Aug 2, 2022
tgolen
left a comment
tgolen
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Thanks for the tests
Contributor
Author
|
Self-merging with approval to unblock Expensify/App#10051 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds
waitForCollectionCallbackas a param toOnyx.connectto trigger a single callback when connecting to a collectioncc @tgolen I found that a
connectToCollectionmethod would share most of its logic withconnectso I added a param instead of creating a new method.Related Issues
Expensify/App#10051 (comment)
Automated Tests
Added to
tests/unit/onyxTest.jsLinked PRs
Expensify/App#10051