Throw in dev if collection keys don't belong to the same parent#277
Merged
Conversation
mountiny
approved these changes
Jul 13, 2023
mountiny
left a comment
mountiny
left a comment
Contributor
There was a problem hiding this comment.
thanks, looks good to me
PauloGasparSv
approved these changes
Jul 13, 2023
Contributor
|
I think we can go ahead with this one as its late for Vivek and Marc has proposed this change before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Coming from this comment, we should make the error easier to catch on dev by throwing it, instead of logging.
cc @marcaaron @mountiny
Related Issues
https://github.com/Expensify/react-native-onyx/pull/272/files#r1261673744
Automated Tests
N/A
Linked PRs
TBD