[Onyx] - Updated lodash dependency to fix vulnerability#53
Merged
Conversation
Luke9389
changed the title
Luke9389
changed the title
bondydaa
approved these changes
Mar 19, 2021
bondydaa
left a comment
bondydaa
left a comment
Contributor
There was a problem hiding this comment.
Can you add a QA section that states regular regressions are all that are needed, no special tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @tgolen
Details
Rather than using individual packages for each lodash method, we are using the main lodash package and selectively loading the methods we need (using this handy syntax:
lodash/merge)Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157899Web QA
Just regular regression testing will suffice for this. No special tests are needed. Thanks!