-
Notifications
You must be signed in to change notification settings - Fork 95
Make Onyx.getAllKeys public #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
98d8359
Allow mergeCollection to also clear any removed keys
Gonals 7433385
add unit test
Gonals 1c647fe
update test
Gonals 19451f0
lint
Gonals a3e2aa9
update tests
Gonals 9d9fbe0
update tests
Gonals c71c10a
comment
Gonals 4c78c13
remove tests
Gonals c9d3c03
remove comments
Gonals b7a058c
style
Gonals d28c0f4
Move logic to new method
Gonals 9d873f8
cleanup
Gonals e616668
lint
Gonals c2685c6
Make getAllKeys public
Gonals File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -783,6 +783,7 @@ function init({ | |
| const Onyx = { | ||
| connect, | ||
| disconnect, | ||
| getAllKeys, | ||
| set, | ||
| multiSet, | ||
| merge, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just see which keys exist by subscribing to the collection? If the new value that comes back from the API is different then what we have here then just remove those keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, very true. Closing this PR, since we no longer need it. Thanks for all the input!