update to java 17

[Sheikah45]

Fixes #2298

[Sheikah45]

bah no official jacoco support for javaFX yet

[jnorthrup]

i really want the benefit of raising the maxversion well beyond 17 since there is an aggressive java update tempo and this codebasee sees some pretty long iterations of updates.

if 15 works 15 should stay the minversion as well.

i'm not comprehending the role of the fx package here or at least the potential to spoil the whole build by failing to be exact in this matter.

i would suggest sdkman as a shell based jvm tool to install jdk's, which includes the suggested adoptjdk ones, while they current that is. again, i have no idea about fx and jacoco

[Sheikah45]

You can technically modify the install script to allow greater than java 15 although this is only pertinent for linux installs as windows has the jre packaged with it

[jnorthrup]

what is the gap between having install4j and using gradle to make a shade/uberjar that just does the simplest thing expected?

[Sheikah45]

install4j produces a native exe and also packages the necessary jre.

Using gradle would just produce a zip or a fat jar but users would still need to install the appropriate version of java to run it and also would have to invoke the java command themself

[jnorthrup]

the non-windows version requires rather lengthy shell-pasting detours to accomodate the window-binary preferences then, iiuc.

I have identified a bug in replays on linux i'd like to fix, where the client is invoking shell on the FA executable. i have not gone deeper than this github issue to understand the relative complexity required.

All told, it appears my install gist ( https://gist.github.com/Yoslincake/ddfa6f3f1aedfb6faa5f17ddd7d12f28 ) requires no less than 2 shell scripts and a jdk15 appendage and and a lot of non-windows directory magic like ~/.fafclient seperate from ~/games/faf

This would be simpler (e.g. not deflect FA players for years at a time who can't be bothered) as your described with an executable jarfile or a shell script with environment.

[Sheikah45]

The client infrastructure only officially supports windows as this is the supported platform for the game as well. There is no official support for linux as there are no devs who are actively working on it who also play on that environment to support it.

That is the reason why the linux path is more tedious simply because it doesn't have any support.

[Sheikah45]

The unofficial support guide someone put together can be found here https://wiki.faforever.com/en/FAQ/Client-Setup. There is also a forum post that people have put some of their findings on that you can take a look at https://forum.faforever.com/topic/12/linux-support

[jnorthrup]

Graalvm can build static executables fwiw, depending on the features[not] used

…

On Sun, Feb 27, 2022, 11:51 AM Sheikah45 ***@***.***> wrote: The unofficial support guide someone put together can be found here https://wiki.faforever.com/en/FAQ/Client-Setup. There is also a forum post that people have put some of their findings on that you can take a look at https://forum.faforever.com/topic/12/linux-support — Reply to this email directly, view it on GitHub <#2405 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAR6KUYBECL4GMA5YTGBN3U5GNSXANCNFSM5GSIVFQQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

[Brutus5000]

GraalVM is not approachable and never will be. Even for simple backend Spring apps it mostly doesn't work yet.

We can't guarantee Java17 to work because our test suite fails on 17.

[Sheikah45]

Superceded by #2623