Strip trailing ampersand#3
Open
maxdeviant wants to merge 1 commit into
Open
Conversation
maxdeviant
commented
Jul 28, 2022
| acc + tuple.0 + "=" + tuple.1 + "&" | ||
| }) | ||
| .trim_end_matches('&') | ||
| .to_string() |
Author
There was a problem hiding this comment.
I'm not 100% sure, but I think this might add an additional allocation.
It seemed like the best approach given the possibility space I could think of; not sure if there's room/a need to optimize further.
maxdeviant
commented
Jul 28, 2022
| /// extern crate querystring; | ||
| /// | ||
| /// assert_eq!(querystring::stringify(vec![("foo", "bar"), ("baz", "qux")]), "foo=bar&baz=qux&"); | ||
| /// assert_eq!(querystring::stringify(vec![("foo", "bar"), ("baz", "qux")]), "foo=bar&baz=qux"); |
Author
There was a problem hiding this comment.
I updated the doctest here, but am happy to add additional tests!
maxdeviant
force-pushed
the
strip-trailing-ampersand
branch
from
dc9570c to
7a5eb0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so the trailing ampersand (
&) is stripped when usingstringify.Fixes #2.